From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, pbonzini@redhat.com,
alex.williamson@redhat.com, armbru@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile
Date: Mon, 27 Oct 2014 18:41:20 +0200 [thread overview]
Message-ID: <1414428082-7341-1-git-send-email-marcel.a@redhat.com> (raw)
Hot-plugging a device that has a romfile (either supplied by user
or built-in) using rombar=0 option is an user error,
do not allow the device to be hot-plugged.
v2 -> v3:
- Reverse the decision to forbit the hotplug on user error (Michael S. Tsirkin)
- Split the patch in two, first part being a separate fix (Markus Armbruster)
v1 -> v2:
After a discussion with Michael, Paolo and Alex, this
patch silent drops the romfile instead of not allowing
the hotplug.
Marcel Apfelbaum (2):
hw/pci: fixed error flow in pci_qdev_init
hw/pci: fixed hotplug crash when using rombar=0 with devices having
romfile
hw/pci/pci.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
--
1.8.3.1
next reply other threads:[~2014-10-27 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 16:41 Marcel Apfelbaum [this message]
2014-10-27 16:41 ` [Qemu-devel] [PATCH v3 1/2] hw/pci: fixed error flow in pci_qdev_init Marcel Apfelbaum
2014-10-27 16:41 ` [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile Marcel Apfelbaum
2014-10-27 17:10 ` Eric Blake
2014-10-27 17:15 ` Marcel Apfelbaum
2014-10-27 17:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414428082-7341-1-git-send-email-marcel.a@redhat.com \
--to=marcel.a@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).