From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XioCk-0006Da-MF for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XioCe-0002B9-C4 for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:35:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XioCe-0002B4-3a for qemu-devel@nongnu.org; Mon, 27 Oct 2014 13:35:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9RHZZDr020401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 27 Oct 2014 13:35:35 -0400 From: Marcel Apfelbaum Date: Mon, 27 Oct 2014 19:34:40 +0200 Message-Id: <1414431282-9839-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH v4 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, armbru@redhat.com, alex.williamson@redhat.com, marcel@redhat.com, pbonzini@redhat.com Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is a user error, do not allow the device to be hot-plugged. v3 -> v4: - Fixed a typo in the commit (Eric Blake) v2 -> v3: - Reverse the decision to forbid the hotplug on user error (Michael S. Tsirkin) - Split the patch in two, first part being a separate fix (Markus Armbruster) v1 -> v2: After a discussion with Michael, Paolo and Alex, this patch silent drops the romfile instead of not allowing the hotplug. Marcel Apfelbaum (2): hw/pci: fixed error flow in pci_qdev_init hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile hw/pci/pci.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 1.8.3.1