From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj3Rn-0000nw-11 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 05:52:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj3Rc-0000V2-8j for qemu-devel@nongnu.org; Tue, 28 Oct 2014 05:52:14 -0400 From: Gerd Hoffmann Date: Tue, 28 Oct 2014 10:50:38 +0100 Message-Id: <1414489842-27535-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1414489842-27535-1-git-send-email-kraxel@redhat.com> References: <1414489842-27535-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/5] vmware-vga: CVE-2014-3689: turn off hw accel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, pmatouse@redhat.com, Intel.Product.Security.Incident.Response.Team@intel.com, Don Koch , Gerd Hoffmann Quick & easy stopgap for CVE-2014-3689: We just compile out the hardware acceleration functions which lack sanity checks. Thankfully we have capability bits for them (SVGA_CAP_RECT_COPY and SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory. Subsequent patches will add the missing checks and re-enable the hardware acceleration emulation. Cc: qemu-stable@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch --- hw/display/vmware_vga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 0c36c72..ec63290 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -29,8 +29,10 @@ #include "hw/pci/pci.h" #undef VERBOSE +#if 0 #define HW_RECT_ACCEL #define HW_FILL_ACCEL +#endif #define HW_MOUSE_ACCEL #include "vga_int.h" -- 1.8.3.1