From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj4Uz-0002z3-W9 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 06:59:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xj4Uv-0005TB-6k for qemu-devel@nongnu.org; Tue, 28 Oct 2014 06:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xj4Uu-0005T5-W7 for qemu-devel@nongnu.org; Tue, 28 Oct 2014 06:59:33 -0400 From: Gerd Hoffmann Date: Tue, 28 Oct 2014 11:59:19 +0100 Message-Id: <1414493959-8310-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1414493959-8310-1-git-send-email-kraxel@redhat.com> References: <1414493959-8310-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 2/2] vnc: return directly if no vnc client connected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: ChenLiang , Gonglei , Gerd Hoffmann , Anthony Liguori From: ChenLiang graphic_hw_update and vnc_refresh_server_surface aren't need to do when no vnc client connected. It can reduce lock contention, because vnc_refresh will hold global big lock two millisecond every three seconds. Signed-off-by: ChenLiang Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8bca597..5707015 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2778,6 +2778,11 @@ static void vnc_refresh(DisplayChangeListener *dcl) VncState *vs, *vn; int has_dirty, rects = 0; + if (QTAILQ_EMPTY(&vd->clients)) { + update_displaychangelistener(&vd->dcl, VNC_REFRESH_INTERVAL_MAX); + return; + } + graphic_hw_update(NULL); if (vnc_trylock_display(vd)) { @@ -2793,11 +2798,6 @@ static void vnc_refresh(DisplayChangeListener *dcl) /* vs might be free()ed here */ } - if (QTAILQ_EMPTY(&vd->clients)) { - update_displaychangelistener(&vd->dcl, VNC_REFRESH_INTERVAL_MAX); - return; - } - if (has_dirty && rects) { vd->dcl.update_interval /= 2; if (vd->dcl.update_interval < VNC_REFRESH_INTERVAL_BASE) { -- 1.8.3.1