qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 0/5] target-arm: Avoid passing CPUARMState around the decoder
Date: Tue, 28 Oct 2014 19:23:59 +0000	[thread overview]
Message-ID: <1414524244-20316-1-git-send-email-peter.maydell@linaro.org> (raw)

This is a set of cleanup patches which avoid passing CPUARMState
around the decoder unnecessarily, since we were pretty much only
using it to check feature bits, which we now also have in the
DisasContext structure.

We still pass CPUARMState into disas_thumb_insn() and disas_thumb2_insn()
purely so they can read the instruction with arm_lduw_code(). I couldn't
think of a good way to approach this since you basically don't know
if you're going to need to load the second halfword until a long way
into the decode. Still, keeping the env pointer out of all the ARM,
VFP and Neon decode seems like a good first step.


Peter Maydell (5):
  target-arm/translate.c: Use arm_dc_feature() in ENABLE_ARCH_ macros
  target-arm/translate.c: Use arm_dc_feature() rather than arm_feature()
  target-arm/translate.c: Don't use IS_M()
  target-arm/translate.c: Don't pass CPUARMState around in the decoder
  target-arm/translate.c: Don't pass CPUARMState * to disas_arm_insn()

 target-arm/translate.c | 280 +++++++++++++++++++++++++++----------------------
 1 file changed, 154 insertions(+), 126 deletions(-)

-- 
1.9.1

             reply	other threads:[~2014-10-28 19:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 19:23 Peter Maydell [this message]
2014-10-28 19:24 ` [Qemu-devel] [PATCH 1/5] target-arm/translate.c: Use arm_dc_feature() in ENABLE_ARCH_ macros Peter Maydell
2014-10-31 13:09   ` Alex Bennée
2014-11-04  9:04   ` Claudio Fontana
2014-11-04 12:04     ` Peter Maydell
2014-10-28 19:24 ` [Qemu-devel] [PATCH 2/5] target-arm/translate.c: Use arm_dc_feature() rather than arm_feature() Peter Maydell
2014-10-31 13:40   ` Alex Bennée
2014-11-04  9:02   ` Claudio Fontana
2014-10-28 19:24 ` [Qemu-devel] [PATCH 3/5] target-arm/translate.c: Don't use IS_M() Peter Maydell
2014-10-31 13:42   ` Alex Bennée
2014-11-04  0:38     ` Peter Maydell
2014-11-04  8:59   ` Claudio Fontana
2014-10-28 19:24 ` [Qemu-devel] [PATCH 4/5] target-arm/translate.c: Don't pass CPUARMState around in the decoder Peter Maydell
2014-10-31 13:43   ` Alex Bennée
2014-11-04  8:57   ` Claudio Fontana
2014-10-28 19:24 ` [Qemu-devel] [PATCH 5/5] target-arm/translate.c: Don't pass CPUARMState * to disas_arm_insn() Peter Maydell
2014-10-31 13:47   ` Alex Bennée
2014-11-04  0:40     ` Peter Maydell
2014-11-04  8:55   ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414524244-20316-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).