From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjO50-0000Pp-6G for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:54:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjO4q-0008VR-6Q for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:54:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56469 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjO4q-0008VC-00 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 03:53:56 -0400 From: Hannes Reinecke Date: Wed, 29 Oct 2014 08:53:45 +0100 Message-Id: <1414569232-21357-11-git-send-email-hare@suse.de> In-Reply-To: <1414569232-21357-1-git-send-email-hare@suse.de> References: <1414569232-21357-1-git-send-email-hare@suse.de> Subject: [Qemu-devel] [PATCH 10/17] megasas: Fix typo in megasas_dcmd_ld_get_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hannes Reinecke , Paolo Bonzini , Nic Bellinger , Andreas Faerber , Alexander Graf The check for a valid command buffer size was inverted. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 00c1d5c..f5c4318 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1119,7 +1119,7 @@ static int megasas_dcmd_ld_get_list(MegasasState *s, MegasasCmd *cmd) BusChild *kid; memset(&info, 0, dcmd_size); - if (cmd->iov_size < dcmd_size) { + if (cmd->iov_size > dcmd_size) { trace_megasas_dcmd_invalid_xfer_len(cmd->index, cmd->iov_size, dcmd_size); return MFI_STAT_INVALID_PARAMETER; -- 1.8.4.5