From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsvTB-00041R-Hh for qemu-devel@nongnu.org; Mon, 24 Nov 2014 10:22:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsvT1-0000k7-M8 for qemu-devel@nongnu.org; Mon, 24 Nov 2014 10:22:29 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:49150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsvT1-0000jt-G5 for qemu-devel@nongnu.org; Mon, 24 Nov 2014 10:22:19 -0500 Received: by mail-wi0-f173.google.com with SMTP id r20so6022769wiv.6 for ; Mon, 24 Nov 2014 07:22:18 -0800 (PST) Message-ID: <1414676475.12380.8.camel@localhost.localdomain> From: Marcel Apfelbaum In-Reply-To: <1414431282-9839-1-git-send-email-marcel.a@redhat.com> References: <1414431282-9839-1-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile Reply-To: marcel.a@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Mon, 24 Nov 2014 15:22:38 -0000 To: mst@redhat.com Cc: qemu-devel@nongnu.org On Mon, 2014-10-27 at 19:34 +0200, Marcel Apfelbaum wrote: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=0 option is a user error, > do not allow the device to be hot-plugged. Hi Michael, The series has been reviewed, can you please add it to your next PULL request? Thanks, Marcel > > v3 -> v4: > - Fixed a typo in the commit (Eric Blake) > > v2 -> v3: > - Reverse the decision to forbid the hotplug on user error (Michael S. Tsirkin) > - Split the patch in two, first part being a separate fix (Markus Armbruster) > > v1 -> v2: > After a discussion with Michael, Paolo and Alex, this > patch silent drops the romfile instead of not allowing > the hotplug. > > Marcel Apfelbaum (2): > hw/pci: fixed error flow in pci_qdev_init > hw/pci: fixed hotplug crash when using rombar=0 with devices having > romfile > > hw/pci/pci.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >