* [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes
@ 2014-10-31 16:06 Tom Musta
2014-11-03 15:42 ` Thomas Huth
2014-11-03 17:55 ` Alexander Graf
0 siblings, 2 replies; 3+ messages in thread
From: Tom Musta @ 2014-10-31 16:06 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: Tom Musta, agraf
Correct the opcodes for the vrfim, vrfin and vrfiz instructions.
Signed-off-by: Tom Musta <tommusta@gmail.com>
---
target-ppc/translate.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 4a00935..c064cc9 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -7286,10 +7286,10 @@ GEN_VXFORM_NOA_ENV(vrefp, 5, 4);
GEN_VXFORM_NOA_ENV(vrsqrtefp, 5, 5);
GEN_VXFORM_NOA_ENV(vexptefp, 5, 6);
GEN_VXFORM_NOA_ENV(vlogefp, 5, 7);
-GEN_VXFORM_NOA_ENV(vrfim, 5, 8);
-GEN_VXFORM_NOA_ENV(vrfin, 5, 9);
+GEN_VXFORM_NOA_ENV(vrfim, 5, 11);
+GEN_VXFORM_NOA_ENV(vrfin, 5, 8);
GEN_VXFORM_NOA_ENV(vrfip, 5, 10);
-GEN_VXFORM_NOA_ENV(vrfiz, 5, 11);
+GEN_VXFORM_NOA_ENV(vrfiz, 5, 9);
#define GEN_VXFORM_SIMM(name, opc2, opc3) \
static void glue(gen_, name)(DisasContext *ctx) \
@@ -10524,10 +10524,10 @@ GEN_VXFORM_NOA(vrefp, 5, 4),
GEN_VXFORM_NOA(vrsqrtefp, 5, 5),
GEN_VXFORM_NOA(vexptefp, 5, 6),
GEN_VXFORM_NOA(vlogefp, 5, 7),
-GEN_VXFORM_NOA(vrfim, 5, 8),
-GEN_VXFORM_NOA(vrfin, 5, 9),
+GEN_VXFORM_NOA(vrfim, 5, 11),
+GEN_VXFORM_NOA(vrfin, 5, 8),
GEN_VXFORM_NOA(vrfip, 5, 10),
-GEN_VXFORM_NOA(vrfiz, 5, 11),
+GEN_VXFORM_NOA(vrfiz, 5, 9),
#undef GEN_VXFORM_UIMM
#define GEN_VXFORM_UIMM(name, opc2, opc3) \
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes
2014-10-31 16:06 [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes Tom Musta
@ 2014-11-03 15:42 ` Thomas Huth
2014-11-03 17:55 ` Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2014-11-03 15:42 UTC (permalink / raw)
To: Tom Musta; +Cc: qemu-ppc, qemu-devel, agraf
On Fri, 31 Oct 2014 11:06:15 -0500
Tom Musta <tommusta@gmail.com> wrote:
> Correct the opcodes for the vrfim, vrfin and vrfiz instructions.
>
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
> target-ppc/translate.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 4a00935..c064cc9 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -7286,10 +7286,10 @@ GEN_VXFORM_NOA_ENV(vrefp, 5, 4);
> GEN_VXFORM_NOA_ENV(vrsqrtefp, 5, 5);
> GEN_VXFORM_NOA_ENV(vexptefp, 5, 6);
> GEN_VXFORM_NOA_ENV(vlogefp, 5, 7);
> -GEN_VXFORM_NOA_ENV(vrfim, 5, 8);
> -GEN_VXFORM_NOA_ENV(vrfin, 5, 9);
> +GEN_VXFORM_NOA_ENV(vrfim, 5, 11);
> +GEN_VXFORM_NOA_ENV(vrfin, 5, 8);
> GEN_VXFORM_NOA_ENV(vrfip, 5, 10);
> -GEN_VXFORM_NOA_ENV(vrfiz, 5, 11);
> +GEN_VXFORM_NOA_ENV(vrfiz, 5, 9);
>
> #define GEN_VXFORM_SIMM(name, opc2, opc3) \
> static void glue(gen_, name)(DisasContext *ctx) \
> @@ -10524,10 +10524,10 @@ GEN_VXFORM_NOA(vrefp, 5, 4),
> GEN_VXFORM_NOA(vrsqrtefp, 5, 5),
> GEN_VXFORM_NOA(vexptefp, 5, 6),
> GEN_VXFORM_NOA(vlogefp, 5, 7),
> -GEN_VXFORM_NOA(vrfim, 5, 8),
> -GEN_VXFORM_NOA(vrfin, 5, 9),
> +GEN_VXFORM_NOA(vrfim, 5, 11),
> +GEN_VXFORM_NOA(vrfin, 5, 8),
> GEN_VXFORM_NOA(vrfip, 5, 10),
> -GEN_VXFORM_NOA(vrfiz, 5, 11),
> +GEN_VXFORM_NOA(vrfiz, 5, 9),
>
> #undef GEN_VXFORM_UIMM
> #define GEN_VXFORM_UIMM(name, opc2, opc3) \
Looks right to me.
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes
2014-10-31 16:06 [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes Tom Musta
2014-11-03 15:42 ` Thomas Huth
@ 2014-11-03 17:55 ` Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2014-11-03 17:55 UTC (permalink / raw)
To: Tom Musta, qemu-devel, qemu-ppc
On 31.10.14 17:06, Tom Musta wrote:
> Correct the opcodes for the vrfim, vrfin and vrfiz instructions.
>
> Signed-off-by: Tom Musta <tommusta@gmail.com>
Thanks, applied to ppc-next.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-03 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 16:06 [Qemu-devel] [PATCH] target-ppc: Fix Altivec Round Opcodes Tom Musta
2014-11-03 15:42 ` Thomas Huth
2014-11-03 17:55 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).