qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, John Snow <jsnow@redhat.com>,
	armbru@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes
Date: Fri, 31 Oct 2014 16:03:36 -0400	[thread overview]
Message-ID: <1414785819-26209-1-git-send-email-jsnow@redhat.com> (raw)

This is a v2 patch series that collects patches 3, 4 and 5
from the v1 series that was only partially merged.

This series, as a subset, generally cleans up the usage and
handling of the scatter-gather list implementation in QEMU
that interacts with the PRDT (Physical Region Descriptor Table)
in AHCI.

We also repair a small oversight with PIO transfers.

This series currently applies cleanly to stefanha's block staging
tree, but can be trivially merged to master.

v2:
- Reset io_buffer_offset to 0 at the beginning of ide_exec_cmd,
  which will reset it for PIO I/O and all ATAPI commands.
  There was an oversight in V1 where we would use junk values for
  PACKET IDENTIFY if it was not the first command.

- Adjust the prepare_buf() callback to return, simply, the number
  of bytes it was able to prepare, or -1 on error. This resolves
  an ambiguity around the nature of its return code meaning
  "no sectors" or "no bytes" which led to bad error pathways.

John Snow (3):
  ide: repair PIO transfers for cases where nsector > 1
  ahci: unify sglist preparation
  ide: Correct handling of malformed/short PRDTs

 hw/ide/ahci.c     | 33 ++++++++++++++++++++++++++-------
 hw/ide/core.c     | 14 ++++++++++++--
 hw/ide/internal.h | 13 +++++++------
 hw/ide/macio.c    |  7 ++++++-
 hw/ide/pci.c      | 27 +++++++++++++++++++++------
 5 files changed, 72 insertions(+), 22 deletions(-)

-- 
1.9.3

             reply	other threads:[~2014-10-31 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 20:03 John Snow [this message]
2014-10-31 20:03 ` [Qemu-devel] [block PATCH v2 1/3] ide: repair PIO transfers for cases where nsector > 1 John Snow
2014-10-31 20:03 ` [Qemu-devel] [block PATCH v2 2/3] ahci: unify sglist preparation John Snow
2014-10-31 20:03 ` [Qemu-devel] [block PATCH v2 3/3] ide: Correct handling of malformed/short PRDTs John Snow
2014-11-03 12:35 ` [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes Paolo Bonzini
2014-11-03 19:51   ` John Snow
2014-11-13 10:04 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414785819-26209-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).