From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkNq9-00073v-QT for qemu-devel@nongnu.org; Fri, 31 Oct 2014 21:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XkNq5-0002Fg-10 for qemu-devel@nongnu.org; Fri, 31 Oct 2014 21:50:53 -0400 From: zhanghailiang Date: Sat, 1 Nov 2014 09:50:01 +0800 Message-ID: <1414806603-22556-3-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1414806603-22556-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1414806603-22556-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 2/4] spice-qemu-char: fix check for in-parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: pbonzini@redhat.com, zhanghailiang , qemu-devel@nongnu.org, peter.huangpeng@huawei.com For qemu_chr_open_spice_vmc and qemu_chr_open_spice_port, the in-parameter never to be NULL, because the checks in qemu_chr_parse_spice_vmc and qemu_chr_parse_spice_port have ensured this. So we should check the length of the in-parameter. Signed-off-by: zhanghailiang --- spice-qemu-char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 8106e06..45e7d69 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -290,7 +290,7 @@ CharDriverState *qemu_chr_open_spice_vmc(const char *type) { const char **psubtype = spice_server_char_device_recognized_subtypes(); - if (type == NULL) { + if (type == NULL || strlen(type) == 0) { fprintf(stderr, "spice-qemu-char: missing name parameter\n"); print_allowed_subtypes(); return NULL; @@ -315,7 +315,7 @@ CharDriverState *qemu_chr_open_spice_port(const char *name) CharDriverState *chr; SpiceCharDriver *s; - if (name == NULL) { + if (name == NULL || strlen(name) == 0) { fprintf(stderr, "spice-qemu-char: missing name parameter\n"); return NULL; } -- 1.7.12.4