From: Yongbok Kim <yongbok.kim@imgtec.com>
To: qemu-devel@nongnu.org
Cc: leon.alrae@imgtec.com, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCH v3 03/19] target-mips: remove duplicated mips/ieee mapping function
Date: Sat, 1 Nov 2014 05:28:37 +0000 [thread overview]
Message-ID: <1414819733-30765-4-git-send-email-yongbok.kim@imgtec.com> (raw)
In-Reply-To: <1414819733-30765-1-git-send-email-yongbok.kim@imgtec.com>
Remove the duplicated ieee_rm in gdbstub.c.
Make the other ieee_rm and ieee_ex_to_mips available to other files.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
target-mips/cpu.h | 4 ++++
target-mips/gdbstub.c | 7 -------
target-mips/op_helper.c | 4 ++--
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/target-mips/cpu.h b/target-mips/cpu.h
index d08bbe7..d21da8e 100644
--- a/target-mips/cpu.h
+++ b/target-mips/cpu.h
@@ -760,6 +760,10 @@ hwaddr cpu_mips_translate_address (CPUMIPSState *env, target_ulong address,
#endif
target_ulong exception_resume_pc (CPUMIPSState *env);
+/* op_helper.c */
+extern unsigned int ieee_rm[];
+int ieee_ex_to_mips(int xcpt);
+
static inline void cpu_get_tb_cpu_state(CPUMIPSState *env, target_ulong *pc,
target_ulong *cs_base, int *flags)
{
diff --git a/target-mips/gdbstub.c b/target-mips/gdbstub.c
index 5b72d58..f65fec2 100644
--- a/target-mips/gdbstub.c
+++ b/target-mips/gdbstub.c
@@ -73,13 +73,6 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
return 0;
}
-/* convert MIPS rounding mode in FCR31 to IEEE library */
-static unsigned int ieee_rm[] = {
- float_round_nearest_even,
- float_round_to_zero,
- float_round_up,
- float_round_down
-};
#define RESTORE_ROUNDING_MODE \
set_float_rounding_mode(ieee_rm[env->active_fpu.fcr31 & 3], \
&env->active_fpu.fp_status)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 0c75ec8..7cbf4cf 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -2340,7 +2340,7 @@ void mips_cpu_unassigned_access(CPUState *cs, hwaddr addr,
#define FP_TO_INT64_OVERFLOW 0x7fffffffffffffffULL
/* convert MIPS rounding mode in FCR31 to IEEE library */
-static unsigned int ieee_rm[] = {
+unsigned int ieee_rm[] = {
float_round_nearest_even,
float_round_to_zero,
float_round_up,
@@ -2461,7 +2461,7 @@ void helper_ctc1(CPUMIPSState *env, target_ulong arg1, uint32_t fs, uint32_t rt)
do_raise_exception(env, EXCP_FPE, GETPC());
}
-static inline int ieee_ex_to_mips(int xcpt)
+int ieee_ex_to_mips(int xcpt)
{
int ret = 0;
if (xcpt) {
--
1.7.4
next prev parent reply other threads:[~2014-11-01 5:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 5:28 [Qemu-devel] [PATCH v3 00/19] target-mips: add MSA module Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 01/19] target-mips: add MSA defines and data structure Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 02/19] target-mips: add MSA exceptions Yongbok Kim
2014-11-01 5:28 ` Yongbok Kim [this message]
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 04/19] target-mips: stop translation after ctc1 Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 05/19] target-mips: add MSA opcode enum Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 06/19] target-mips: add msa_reset(), global msa register Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 07/19] target-mips: add msa_helper.c Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 08/19] target-mips: add MSA branch instructions Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 09/19] target-mips: add MSA I8 format instructions Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 10/19] target-mips: add MSA I5 format instruction Yongbok Kim
2014-11-02 17:53 ` Leon Alrae
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 11/19] target-mips: add MSA BIT format instructions Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 12/19] target-mips: add MSA 3R " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 13/19] target-mips: add MSA ELM " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 14/19] target-mips: add MSA 3RF " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 15/19] target-mips: add MSA VEC/2R " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 16/19] target-mips: add MSA 2RF " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 17/19] target-mips: add MSA MI10 " Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 18/19] disas/mips.c: disassemble MSA instructions Yongbok Kim
2014-11-01 5:28 ` [Qemu-devel] [PATCH v3 19/19] target-mips: add MSA support to mips32r5-generic Yongbok Kim
2014-11-02 20:06 ` Leon Alrae
2014-11-02 22:14 ` [Qemu-devel] [PATCH v3 00/19] target-mips: add MSA module Leon Alrae
2014-11-02 23:08 ` Peter Maydell
2014-11-03 10:54 ` Leon Alrae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414819733-30765-4-git-send-email-yongbok.kim@imgtec.com \
--to=yongbok.kim@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).