From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlECO-0006iu-18 for qemu-devel@nongnu.org; Mon, 03 Nov 2014 04:45:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlECJ-0000Cg-GY for qemu-devel@nongnu.org; Mon, 03 Nov 2014 04:45:19 -0500 From: zhanghailiang Date: Mon, 3 Nov 2014 17:44:29 +0800 Message-ID: <1415007872-8228-3-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1415007872-8228-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1415007872-8228-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2 2/5] qemu-char: remove unnecessary in-parameter check for qemu_chr_parse_pipe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: zhanghailiang , mjt@tls.msk.ru, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com The check has been done in qemu_chr_parse_pipe, so we don't need to check it again in qemu_chr_parse_pipe. Signed-off-by: zhanghailiang --- qemu-char.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 04d747a..e1f0e28 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1084,11 +1084,6 @@ static CharDriverState *qemu_chr_open_pipe(ChardevHostdev *opts) char filename_out[CHR_MAX_FILENAME_SIZE]; const char *filename = opts->device; - if (filename == NULL) { - fprintf(stderr, "chardev: pipe: no filename given\n"); - return NULL; - } - snprintf(filename_in, CHR_MAX_FILENAME_SIZE, "%s.in", filename); snprintf(filename_out, CHR_MAX_FILENAME_SIZE, "%s.out", filename); TFR(fd_in = qemu_open(filename_in, O_RDWR | O_BINARY)); -- 1.7.12.4