qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-trivial@nongnu.org
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	armbru@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org,
	peter.huangpeng@huawei.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/5] Trivial patch about qemu-char
Date: Tue, 4 Nov 2014 18:50:18 +0800	[thread overview]
Message-ID: <1415098223-32404-1-git-send-email-zhang.zhanghailiang@huawei.com> (raw)

Patch 1 and 2 fix check about parameter in chr_parse_* functions.
Patch 3 fix wrong english state in error message in windows part of the code.
The last two patches convert some open functions to use Error API.

In patch 4, i have tried to convert some codes which will be used 
in windows hypervisor. I didn't test them. But this is not too complex.

Markus has suggested add a separate patch for print_allowed_subtypes to use
error_prinf, but i think it's also in the context of "use Error API", so 
i fix it togther in patch 5.

v3:
- discard wrong modify about qemu_chr_open_pty (Michael Tokarev)
- use !str[0] in place of strlen(str) == 0 which makes more sense for parameter check (Michael Tokarev)
- Merge v2's patch 1 and 2 into a single patch (Michael Tokarev)
- Add new patch 3 to fix wrong english state in error message
- Use error_prinf instead of fprint for print_allowed_subtypes (Markus Armbruster) 

v2:
- don't use error_setg when followed by exit(), it does not report an error (Eric Blake)
- check the parameter in qemu_chr_parse_* functions and remove the check in qemu_chr_open_* functions. (Michael Tokarev)

Thanks very much for their reviews and suggestions;)

zhanghailiang (5):
  qemu-char: fix parameter check in some qemu_chr_parse_* functions
  spice-qemu-char: fix parameter checks in qemu_chr_parse_* functions
  qemu-char: fix incorrect state in error message
  qemu-char: convert some open functions to use Error API
  spice-qemu-char: convert some functions to use Error API

 include/ui/qemu-spice.h     |  2 +-
 qemu-char.c                 | 93 +++++++++++++++++++++++----------------------
 spice-qemu-char.c           | 26 ++++---------
 stubs/qemu-chr-open-spice.c |  2 +-
 4 files changed, 57 insertions(+), 66 deletions(-)

-- 
1.7.12.4

             reply	other threads:[~2014-11-04 10:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 10:50 zhanghailiang [this message]
2014-11-04 10:50 ` [Qemu-devel] [PATCH v3 1/5] qemu-char: fix parameter check in some qemu_chr_parse_* functions zhanghailiang
2014-11-04 13:25   ` Alex Bennée
2014-11-05  7:05     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-11-05 12:19       ` zhanghailiang
2014-11-05 13:28         ` Alex Bennée
2014-11-04 10:50 ` [Qemu-devel] [PATCH v3 2/5] spice-qemu-char: fix parameter checks in " zhanghailiang
2014-11-04 13:27   ` Alex Bennée
2014-11-04 10:50 ` [Qemu-devel] [PATCH v3 3/5] qemu-char: fix incorrect state in error message zhanghailiang
2014-11-04 13:31   ` Alex Bennée
2014-11-05  7:08   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-11-04 10:50 ` [Qemu-devel] [PATCH v3 4/5] qemu-char: convert some open functions to use Error API zhanghailiang
2014-11-04 13:39   ` Alex Bennée
2014-11-05  7:15     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-11-05  9:08       ` Markus Armbruster
2014-11-04 10:50 ` [Qemu-devel] [PATCH v3 5/5] spice-qemu-char: convert some " zhanghailiang
2014-11-04 13:41   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415098223-32404-1-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).