qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: rth@twiddle.net
Cc: kbastian@mail.uni-paderborn.de, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/2] s390x: Fix sclp console input
Date: Tue,  4 Nov 2014 13:21:47 +0100	[thread overview]
Message-ID: <1415103708-115450-2-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1415103708-115450-1-git-send-email-agraf@suse.de>

When injecting an sclp console interrupt into the guest, we increase
the PC by 4 for some reason. I have no idea why I put that code there,
but it's clearly wrong. Remove the increment.

This patch fixes sclp serial input for the ccw machine.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 target-s390x/interrupt.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target-s390x/interrupt.c b/target-s390x/interrupt.c
index 23a9114..1404d0a 100644
--- a/target-s390x/interrupt.c
+++ b/target-s390x/interrupt.c
@@ -22,9 +22,7 @@ void s390_sclp_extint(uint32_t parm)
         kvm_s390_service_interrupt(parm);
     } else {
         S390CPU *dummy_cpu = s390_cpu_addr2state(0);
-        CPUS390XState *env = &dummy_cpu->env;
 
-        env->psw.addr += 4;
         cpu_inject_ext(dummy_cpu, EXT_SERVICE, parm, 0);
     }
 }
-- 
1.7.12.4

  reply	other threads:[~2014-11-04 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 12:21 [Qemu-devel] [PATCH 0/2] s390x: virtio-less ccw target enablement Alexander Graf
2014-11-04 12:21 ` Alexander Graf [this message]
2014-11-04 19:05   ` [Qemu-devel] [PATCH 1/2] s390x: Fix sclp console input Bastian Koppelmann
2014-11-04 12:21 ` [Qemu-devel] [PATCH 2/2] s390x: Ignore sam31 Alexander Graf
2014-11-04 18:40   ` Bastian Koppelmann
2014-11-04 19:06     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415103708-115450-2-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).