qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PULL v2 2/5] target-i386: Disable CPUID_ACPI by default in KVM mode
Date: Tue,  4 Nov 2014 17:30:44 +0100	[thread overview]
Message-ID: <1415118647-16359-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1415118647-16359-1-git-send-email-afaerber@suse.de>

From: Eduardo Habkost <ehabkost@redhat.com>

KVM never supported the CPUID_ACPI flag, so it doesn't make sense to
have it enabled by default when KVM is enabled.

The motivation here is exactly the same we had for the MONITOR flag
(disabled by commit 136a7e9a85d7047461f8153f7d12c514a3d68f69).

And like in the MONITOR flag case, we don't need machine-type compat code
because it is currently impossible to run a KVM VM with the ACPI flag set.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-i386/cpu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1b25965..727416e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -459,6 +459,7 @@ static uint32_t kvm_default_features[FEATURE_WORDS] = {
 /* Features that are not added by default to any CPU model when KVM is enabled.
  */
 static uint32_t kvm_default_unset_features[FEATURE_WORDS] = {
+    [FEAT_1_EDX] = CPUID_ACPI,
     [FEAT_1_ECX] = CPUID_EXT_MONITOR,
 };
 
-- 
1.8.4.5

  parent reply	other threads:[~2014-11-04 16:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 16:30 [Qemu-devel] [PULL v2 0/5] QOM CPUState patch queue 2014-11-04 Andreas Färber
2014-11-04 16:30 ` [Qemu-devel] [PULL v2 1/5] target-i386: Rename KVM auto-feature-enable compat function Andreas Färber
2014-11-04 16:30 ` Andreas Färber [this message]
2014-11-04 16:30 ` [Qemu-devel] [PULL v2 3/5] target-i386: Remove unsupported bits from all CPU models Andreas Färber
2014-11-04 16:30 ` [Qemu-devel] [PULL v2 4/5] target-i386: Don't enable nested VMX by default Andreas Färber
2014-11-04 16:30 ` [Qemu-devel] [PULL v2 5/5] target-i386: Disable SVM by default in KVM mode Andreas Färber
2014-11-04 17:24 ` [Qemu-devel] [PULL v2 0/5] QOM CPUState patch queue 2014-11-04 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415118647-16359-3-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).