From: Alex Williamson <alex.williamson@redhat.com>
To: Eric Auger <eric.auger@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu, eric.auger@st.com,
thuth@linux.vnet.ibm.com, patches@linaro.org, aik@ozlabs.ru,
mtosatti@redhat.com, qemu-devel@nongnu.org, agraf@suse.de,
borntraeger@de.ibm.com, bsd@redhat.com, qemu-ppc@nongnu.org,
cornelia.huck@de.ibm.com, pbonzini@redhat.com,
peter.maydell@linaro.org, afaerber@suse.de,
christoffer.dall@linaro.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 2/2] vfio: use kvm_resamplefds_enabled()
Date: Tue, 04 Nov 2014 15:25:14 -0700 [thread overview]
Message-ID: <1415139914.16601.27.camel@ul30vt.home> (raw)
In-Reply-To: <1414762699-4700-3-git-send-email-eric.auger@linaro.org>
On Fri, 2014-10-31 at 13:38 +0000, Eric Auger wrote:
> Use the kvm_resamplefds_enabled function
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> ---
If someone wants to pick this up:
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Alternatively, provide an ack on patch 1 and I can bring it in through
my tree after 2.2. Thanks,
Alex
> hw/misc/vfio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
> index b5e7981..75bfa1c 100644
> --- a/hw/misc/vfio.c
> +++ b/hw/misc/vfio.c
> @@ -406,7 +406,7 @@ static void vfio_enable_intx_kvm(VFIODevice *vdev)
>
> if (!VFIO_ALLOW_KVM_INTX || !kvm_irqfds_enabled() ||
> vdev->intx.route.mode != PCI_INTX_ENABLED ||
> - !kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
> + !kvm_resamplefds_enabled()) {
> return;
> }
>
> @@ -568,8 +568,7 @@ static int vfio_enable_intx(VFIODevice *vdev)
> * Only conditional to avoid generating error messages on platforms
> * where we won't actually use the result anyway.
> */
> - if (kvm_irqfds_enabled() &&
> - kvm_check_extension(kvm_state, KVM_CAP_IRQFD_RESAMPLE)) {
> + if (kvm_irqfds_enabled() && kvm_resamplefds_enabled()) {
> vdev->intx.route = pci_device_route_intx_to_irq(&vdev->pdev,
> vdev->intx.pin);
> }
next prev parent reply other threads:[~2014-11-04 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 13:38 [Qemu-devel] [PATCH v3 0/2] actual checks of KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE Eric Auger
2014-10-31 13:38 ` [Qemu-devel] [PATCH v3 1/2] KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE checks Eric Auger
2014-10-31 17:15 ` Cornelia Huck
2014-10-31 13:38 ` [Qemu-devel] [PATCH v3 2/2] vfio: use kvm_resamplefds_enabled() Eric Auger
2014-11-04 22:25 ` Alex Williamson [this message]
2014-11-05 10:38 ` Paolo Bonzini
2014-11-03 12:30 ` [Qemu-devel] [PATCH v3 0/2] actual checks of KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415139914.16601.27.camel@ul30vt.home \
--to=alex.williamson@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=borntraeger@de.ibm.com \
--cc=bsd@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).