From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XlwG0-0003e2-Kn
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:48:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XlwFr-0007cJ-Fj
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:48:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XlwFr-0007c7-8r
	for qemu-devel@nongnu.org; Wed, 05 Nov 2014 03:47:51 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA58loSk031778
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 5 Nov 2014 03:47:50 -0500
Message-ID: <1415177267.11011.1.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 05 Nov 2014 09:47:47 +0100
In-Reply-To: <1415119766-9745-1-git-send-email-akong@redhat.com>
References: <1415119766-9745-1-git-send-email-akong@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ui/input: strictly check console in
 finding input handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On Mi, 2014-11-05 at 00:49 +0800, Amos Kong wrote:
> qemu_input_find_handler() prefers a handler associated with con.
> But if none exists, it takes any. This patch added a parameter
> to strictly check console, in case we want to input event to
> special console.
> 
> 'input-send-event' has a parameter to assign special console,
> so we should enable strict checking in finding handler.

I don't think we want do that by default.  It only matters in case of a
multiseat setup where you actually have multiple input devices of the
same kind.  Which isn't a very typical use case.

Options I see are:

  (a) Turn console into an optional parameter, do strict checking in
      case it is present.
  (b) Add a optional 'strict' parameter.

cheers,
  Gerd