From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm8Wu-0003ox-HI for qemu-devel@nongnu.org; Wed, 05 Nov 2014 16:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm8Wo-00074Y-BW for qemu-devel@nongnu.org; Wed, 05 Nov 2014 16:54:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm8Wo-00074M-2z for qemu-devel@nongnu.org; Wed, 05 Nov 2014 16:54:10 -0500 From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Date: Wed, 5 Nov 2014 22:53:31 +0100 Message-Id: <1415224413-13972-2-git-send-email-rkrcmar@redhat.com> In-Reply-To: <1415224413-13972-1-git-send-email-rkrcmar@redhat.com> References: <1415224413-13972-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/3] target-i386: add apicid_pkg_width to topology.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , =?UTF-8?q?Andreas=20F=C3=A4rber?= The APIC ID topology is made of three elements: smt, core and pkg id; bit width of first two is determined by the actual number of hyperthreads/cores and pkg gets the rest. Basic xAPIC unit tests are included. Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 --- target-i386/topology.h | 13 +++++++++++++ tests/test-x86-cpuid.c | 9 +++++++++ 2 files changed, 22 insertions(+) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..e87a685 100644 --- a/target-i386/topology.h +++ b/target-i386/topology.h @@ -70,6 +70,19 @@ static inline unsigned apicid_core_width(unsigned nr_c= ores, unsigned nr_threads) return apicid_bitwidth_for_count(nr_cores); } =20 +/* Bit width of the Pkg_ID field + */ +static inline unsigned apicid_pkg_width(unsigned nr_cores, + unsigned nr_threads, + unsigned apicid_limit) +{ + unsigned core_smt_width =3D apicid_core_width(nr_cores, nr_threads) = + + apicid_smt_width(nr_cores, nr_threads); + unsigned apicid_width =3D apicid_bitwidth_for_count(apicid_limit); + + return apicid_width > core_smt_width ? apicid_width - core_smt_width= : 0; +} + /* Bit offset of the Core_ID field */ static inline unsigned apicid_core_offset(unsigned nr_cores, diff --git a/tests/test-x86-cpuid.c b/tests/test-x86-cpuid.c index 8d9f96a..6b74f08 100644 --- a/tests/test-x86-cpuid.c +++ b/tests/test-x86-cpuid.c @@ -31,6 +31,8 @@ static void test_topo_bits(void) /* simple tests for 1 thread per core, 1 core per socket */ g_assert_cmpuint(apicid_smt_width(1, 1), =3D=3D, 0); g_assert_cmpuint(apicid_core_width(1, 1), =3D=3D, 0); + g_assert_cmpuint(apicid_pkg_width(1, 1, 255), =3D=3D, 8); + g_assert_cmpuint(apicid_pkg_width(1, 1, 256), =3D=3D, 8); =20 g_assert_cmpuint(x86_apicid_from_cpu_idx(1, 1, 0), =3D=3D, 0); g_assert_cmpuint(x86_apicid_from_cpu_idx(1, 1, 1), =3D=3D, 1); @@ -55,6 +57,13 @@ static void test_topo_bits(void) g_assert_cmpuint(apicid_core_width(32, 2), =3D=3D, 5); g_assert_cmpuint(apicid_core_width(33, 2), =3D=3D, 6); =20 + g_assert_cmpuint(apicid_pkg_width( 2, 2, 255), =3D=3D, 6); + g_assert_cmpuint(apicid_pkg_width(16, 16, 255), =3D=3D, 0); + g_assert_cmpuint(apicid_pkg_width(99, 99, 255), =3D=3D, 0); + g_assert_cmpuint(apicid_pkg_width( 7, 3, 255), =3D=3D, 3); + g_assert_cmpuint(apicid_pkg_width( 8, 3, 255), =3D=3D, 3); + g_assert_cmpuint(apicid_pkg_width( 9, 3, 255), =3D=3D, 2); + g_assert_cmpuint(apicid_pkg_width(12, 6, 255), =3D=3D, 1); =20 /* build a weird topology and see if IDs are calculated correctly */ --=20 2.1.0