* [Qemu-devel] [PATCH] target-mips: fix for missing delay slot in BC1EQZ and BC1NEZ
@ 2014-11-06 10:29 Leon Alrae
2014-11-06 10:42 ` Yongbok Kim
0 siblings, 1 reply; 2+ messages in thread
From: Leon Alrae @ 2014-11-06 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: aurelien
New R6 COP1 conditional branches currently don't have delay slot. Fixing this
by setting MIPS_HFLAG_BDS32 flag which is required for branches having 4-byte
delay slot.
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
target-mips/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index 2117ce8..e83c50a 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -8104,6 +8104,7 @@ static void gen_compute_branch1_r6(DisasContext *ctx, uint32_t op,
MIPS_DEBUG("%s: cond %02x target " TARGET_FMT_lx, opn,
ctx->hflags, btarget);
ctx->btarget = btarget;
+ ctx->hflags |= MIPS_HFLAG_BDS32;
out:
tcg_temp_free_i64(t0);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix for missing delay slot in BC1EQZ and BC1NEZ
2014-11-06 10:29 [Qemu-devel] [PATCH] target-mips: fix for missing delay slot in BC1EQZ and BC1NEZ Leon Alrae
@ 2014-11-06 10:42 ` Yongbok Kim
0 siblings, 0 replies; 2+ messages in thread
From: Yongbok Kim @ 2014-11-06 10:42 UTC (permalink / raw)
To: Leon Alrae, qemu-devel; +Cc: aurelien
On 06/11/2014 10:29, Leon Alrae wrote:
> New R6 COP1 conditional branches currently don't have delay slot. Fixing this
> by setting MIPS_HFLAG_BDS32 flag which is required for branches having 4-byte
> delay slot.
>
> Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
> ---
> target-mips/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 2117ce8..e83c50a 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -8104,6 +8104,7 @@ static void gen_compute_branch1_r6(DisasContext *ctx, uint32_t op,
> MIPS_DEBUG("%s: cond %02x target " TARGET_FMT_lx, opn,
> ctx->hflags, btarget);
> ctx->btarget = btarget;
> + ctx->hflags |= MIPS_HFLAG_BDS32;
>
> out:
> tcg_temp_free_i64(t0);
Reviewed-by: Yongbok Kim <yongbok.kim@imgtec.com>
Regards,
Yongbok Kim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-06 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-06 10:29 [Qemu-devel] [PATCH] target-mips: fix for missing delay slot in BC1EQZ and BC1NEZ Leon Alrae
2014-11-06 10:42 ` Yongbok Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).