* [Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data
@ 2014-11-07 10:43 Yongbok Kim
2014-11-07 10:57 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Yongbok Kim @ 2014-11-07 10:43 UTC (permalink / raw)
To: qemu-devel; +Cc: leon.alrae, aurelien, rth
Avoid to allocate different TCG registers for the FPU registers
that are mapped on the MSA vectore registers.
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
target-mips/translate.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index b43b286..95d8071 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -20200,14 +20200,12 @@ void mips_tcg_init(void)
regnames[i]);
for (i = 0; i < 32; i++) {
- int off = offsetof(CPUMIPSState, active_fpu.fpr[i]);
- fpu_f64[i] = tcg_global_mem_new_i64(TCG_AREG0, off, fregnames[i]);
- }
-
- for (i = 0; i < 32; i++) {
int off = offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]);
msa_wr_d[i * 2] =
tcg_global_mem_new_i64(TCG_AREG0, off, msaregnames[i * 2]);
+ /* The scalar floating-point unit (FPU) registers are mapped on
+ * the MSA vector registers. */
+ fpu_f64[i] = msa_wr_d[i * 2];
off = offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[1]);
msa_wr_d[i * 2 + 1] =
tcg_global_mem_new_i64(TCG_AREG0, off, msaregnames[i * 2 + 1]);
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data
2014-11-07 10:43 [Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data Yongbok Kim
@ 2014-11-07 10:57 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2014-11-07 10:57 UTC (permalink / raw)
To: Yongbok Kim, qemu-devel; +Cc: leon.alrae, aurelien
On 11/07/2014 11:43 AM, Yongbok Kim wrote:
> Avoid to allocate different TCG registers for the FPU registers
> that are mapped on the MSA vectore registers.
>
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> ---
> target-mips/translate.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-07 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-07 10:43 [Qemu-devel] [PATCH] target-mips: fix multiple TCG registers covering same data Yongbok Kim
2014-11-07 10:57 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).