From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnmf4-0005Da-Av for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnmet-0002JF-Ao for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnmet-0002H2-3a for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:19 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAAvHV4002773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 05:57:18 -0500 From: Kevin Wolf Date: Mon, 10 Nov 2014 11:57:08 +0100 Message-Id: <1415617032-12850-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1415617032-12850-1-git-send-email-kwolf@redhat.com> References: <1415617032-12850-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 1/5] qemu-img: Omit error_report() after img_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Max Reitz img_open() already prints an error if the operation failed, so there should not be another error_report() afterwards. Signed-off-by: Max Reitz Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- qemu-img.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 66a7eb4..a42335c 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1126,7 +1126,6 @@ static int img_compare(int argc, char **argv) blk1 = img_open("image_1", filename1, fmt1, flags, true, quiet); if (!blk1) { - error_report("Can't open file %s", filename1); ret = 2; goto out3; } @@ -1134,7 +1133,6 @@ static int img_compare(int argc, char **argv) blk2 = img_open("image_2", filename2, fmt2, flags, true, quiet); if (!blk2) { - error_report("Can't open file %s", filename2); ret = 2; goto out2; } @@ -1482,7 +1480,6 @@ static int img_convert(int argc, char **argv) true, quiet); g_free(id); if (!blk[bs_i]) { - error_report("Could not open '%s'", argv[optind + bs_i]); ret = -1; goto out; } @@ -2962,7 +2959,6 @@ static int img_amend(int argc, char **argv) blk = img_open("image", filename, fmt, flags, true, quiet); if (!blk) { - error_report("Could not open image '%s'", filename); ret = -1; goto out; } -- 1.8.3.1