From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnmey-00055x-25 for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xnmet-0002I3-0u for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnmes-0002GU-Qs for qemu-devel@nongnu.org; Mon, 10 Nov 2014 05:57:18 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAAAvIX9009747 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 10 Nov 2014 05:57:18 -0500 From: Kevin Wolf Date: Mon, 10 Nov 2014 11:57:09 +0100 Message-Id: <1415617032-12850-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1415617032-12850-1-git-send-email-kwolf@redhat.com> References: <1415617032-12850-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 2/5] block: Propagate error in bdrv_img_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com From: Max Reitz If the specified backing file could not be opened, do not generate a new error message which contains the message which has been generated by bdrv_open(), but just propagate the latter. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Peter Lieven Signed-off-by: Kevin Wolf --- block.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/block.c b/block.c index dacd881..4b5735c 100644 --- a/block.c +++ b/block.c @@ -5608,11 +5608,6 @@ void bdrv_img_create(const char *filename, const char *fmt, ret = bdrv_open(&bs, backing_file, NULL, NULL, back_flags, backing_drv, &local_err); if (ret < 0) { - error_setg_errno(errp, -ret, "Could not open '%s': %s", - backing_file, - error_get_pretty(local_err)); - error_free(local_err); - local_err = NULL; goto out; } size = bdrv_getlength(bs); -- 1.8.3.1