* [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops
@ 2014-11-10 11:15 Gerd Hoffmann
2014-11-11 0:45 ` Gonglei
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2014-11-10 11:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/host-libusb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index 032a0e4..a5f9dab 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -749,13 +749,13 @@ static void usb_host_speed_compat(USBHostDevice *s)
udev->speedmask = (1 << udev->speed);
if (udev->speed == USB_SPEED_SUPER && compat_high) {
- udev->speedmask |= USB_SPEED_HIGH;
+ udev->speedmask |= USB_SPEED_MASK_HIGH;
}
if (udev->speed == USB_SPEED_SUPER && compat_full) {
- udev->speedmask |= USB_SPEED_FULL;
+ udev->speedmask |= USB_SPEED_MASK_FULL;
}
if (udev->speed == USB_SPEED_HIGH && compat_full) {
- udev->speedmask |= USB_SPEED_FULL;
+ udev->speedmask |= USB_SPEED_MASK_FULL;
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops
2014-11-10 11:15 [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops Gerd Hoffmann
@ 2014-11-11 0:45 ` Gonglei
0 siblings, 0 replies; 2+ messages in thread
From: Gonglei @ 2014-11-11 0:45 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On 2014/11/10 19:15, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/host-libusb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index 032a0e4..a5f9dab 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -749,13 +749,13 @@ static void usb_host_speed_compat(USBHostDevice *s)
>
> udev->speedmask = (1 << udev->speed);
> if (udev->speed == USB_SPEED_SUPER && compat_high) {
> - udev->speedmask |= USB_SPEED_HIGH;
> + udev->speedmask |= USB_SPEED_MASK_HIGH;
> }
> if (udev->speed == USB_SPEED_SUPER && compat_full) {
> - udev->speedmask |= USB_SPEED_FULL;
> + udev->speedmask |= USB_SPEED_MASK_FULL;
> }
> if (udev->speed == USB_SPEED_HIGH && compat_full) {
> - udev->speedmask |= USB_SPEED_FULL;
> + udev->speedmask |= USB_SPEED_MASK_FULL;
> }
> }
>
Nice catch. :)
Please s/tyops/typos/ in the patch's subject, and of course:
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-11 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-10 11:15 [Qemu-devel] [PATCH] usb-host: fix usb_host_speed_compat tyops Gerd Hoffmann
2014-11-11 0:45 ` Gonglei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).