From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo05Q-00041Z-J7 for qemu-devel@nongnu.org; Mon, 10 Nov 2014 20:17:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xo05F-0007co-Ds for qemu-devel@nongnu.org; Mon, 10 Nov 2014 20:17:36 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:48388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xo05F-0007cj-8R for qemu-devel@nongnu.org; Mon, 10 Nov 2014 20:17:25 -0500 Received: by mail-pa0-f43.google.com with SMTP id eu11so9471948pac.30 for ; Mon, 10 Nov 2014 17:17:24 -0800 (PST) From: Ming Lei Date: Tue, 11 Nov 2014 09:17:09 +0800 Message-Id: <1415668630-30073-2-git-send-email-ming.lei@canonical.com> In-Reply-To: <1415668630-30073-1-git-send-email-ming.lei@canonical.com> References: <1415668630-30073-1-git-send-email-ming.lei@canonical.com> Subject: [Qemu-devel] [PATCH v1 1/2] virtio-scsi: dataplane: fix allocation for 'cmd_vrings' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi , Kevin Wolf Cc: Ming Lei , Fam Zheng , Anthony Liguori , "Michael S. Tsirkin" The size of each element should be sizeof(VirtIOSCSIVring *). Signed-off-by: Ming Lei --- hw/scsi/virtio-scsi-dataplane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 855439e..df17229 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -239,7 +239,7 @@ void virtio_scsi_dataplane_start(VirtIOSCSI *s) if (!s->event_vring) { goto fail_vrings; } - s->cmd_vrings = g_malloc0(sizeof(VirtIOSCSIVring) * vs->conf.num_queues); + s->cmd_vrings = g_new(VirtIOSCSIVring *, vs->conf.num_queues); for (i = 0; i < vs->conf.num_queues; i++) { s->cmd_vrings[i] = virtio_scsi_vring_init(s, vs->cmd_vqs[i], -- 1.7.9.5