From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 5/5] monitor: Fix HMP tab completion
Date: Wed, 12 Nov 2014 17:11:18 +0100 [thread overview]
Message-ID: <1415808678-30795-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1415808678-30795-1-git-send-email-kwolf@redhat.com>
Commands with multiple boolean flag options (like 'info block') didn't
provide correct completion because only the first one was skipped.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 3e7c640..e3219e0 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4698,7 +4698,7 @@ static void monitor_find_completion_by_table(Monitor *mon,
}
}
str = args[nb_args - 1];
- if (*ptype == '-' && ptype[1] != '\0') {
+ while (*ptype == '-' && ptype[1] != '\0') {
ptype = next_arg_type(ptype);
}
switch(*ptype) {
--
1.8.3.1
next prev parent reply other threads:[~2014-11-12 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 16:11 [Qemu-devel] [PATCH v2 0/5] block: QMP cache info and HMP node support Kevin Wolf
2014-11-12 16:11 ` [Qemu-devel] [PATCH v2 1/5] block/qapi: Add cache information to query-block Kevin Wolf
2014-11-12 20:37 ` Eric Blake
2014-11-12 16:11 ` [Qemu-devel] [PATCH v2 2/5] block/hmp: Factor out print_block_info() Kevin Wolf
2014-11-12 16:11 ` [Qemu-devel] [PATCH v2 3/5] block/hmp: Allow info = NULL in print_block_info() Kevin Wolf
2014-11-12 16:11 ` [Qemu-devel] [PATCH v2 4/5] block/hmp: Allow node-name in 'info block' Kevin Wolf
2014-11-12 16:11 ` Kevin Wolf [this message]
2014-11-21 12:38 ` [Qemu-devel] [PATCH v2 0/5] block: QMP cache info and HMP node support Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415808678-30795-6-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).