From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52032)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XovgH-0004DO-Jb
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:47:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XovgB-0006Wh-CH
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:47:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1XovgB-0006WE-5o
	for qemu-devel@nongnu.org; Thu, 13 Nov 2014 09:47:23 -0500
Message-ID: <1415890032.25539.19.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 13 Nov 2014 15:47:12 +0100
In-Reply-To: <ac7a182659785c39058896b7466cf6865c6ae58f.1414507889.git.amit.shah@redhat.com>
References: <ac7a182659785c39058896b7466cf6865c6ae58f.1414507889.git.amit.shah@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/1] virtio: serial: expose a
 'guest_writable' callback for users
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Amos Kong <akong@redhat.com>, qemu list <qemu-devel@nongnu.org>, marcandre.lureau@redhat.com, Markus Armbruster <armbru@redhat.com>

On Di, 2014-10-28 at 20:21 +0530, Amit Shah wrote:
> Users of virtio-serial may want to know when a port becomes writable.  A
> port can stop accepting writes if the guest port is open but not being
> read from.  In this case, data gets queued up in the virtqueue, and
> after the vq is full, writes to the port do not succeed.
> 
> When the guest reads off a vq element, and adds a new one for the host
> to put data in, we can tell users the port is available for more writes,
> via the new ->guest_writable() callback.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>

What is the plan with that one?  I have some spice patches sitting in a
branch depending on this one.  Should it go through virtio queue?  With
some ack from virtio I can also take it through the spice queue,
together with the other patches depending on this one.

It fails checkpatch btw:

=== checkpatch complains ===
ERROR: code indent should never use tabs
#53: FILE: include/hw/virtio/virtio-serial.h:102:
+^I * Guest has enqueued a buffer for the host to write into.$
[ ... more of these snipped ... ]

cheers,
  Gerd