From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: SeokYeon Hwang <syeon.hwang@samsung.com>
Subject: [Qemu-devel] [PULL 12/13] smbios: change 'ram_addr_t' variables to 'uint64_t'
Date: Thu, 13 Nov 2014 16:40:27 +0100 [thread overview]
Message-ID: <1415893228-25823-13-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1415893228-25823-1-git-send-email-pbonzini@redhat.com>
From: SeokYeon Hwang <syeon.hwang@samsung.com>
ram_addr_t should not be used except if referring to a RAMBlobk.
Using 'uint64_t' avoids a -Wconstant-conversion warning, which
clang >= 3.4 produces in "smbios_get_tables()".
Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/i386/smbios.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 8a7ad48..024e594 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -645,7 +645,7 @@ static void smbios_build_type_4_table(unsigned instance)
static void smbios_build_type_16_table(unsigned dimm_cnt)
{
- ram_addr_t size_kb;
+ uint64_t size_kb;
SMBIOS_BUILD_TABLE_PRE(16, 0x1000, true); /* required */
@@ -669,10 +669,10 @@ static void smbios_build_type_16_table(unsigned dimm_cnt)
#define MAX_T17_STD_SZ 0x7FFF /* (32G - 1M), in Megabytes */
#define MAX_T17_EXT_SZ 0x80000000 /* 2P, in Megabytes */
-static void smbios_build_type_17_table(unsigned instance, ram_addr_t size)
+static void smbios_build_type_17_table(unsigned instance, uint64_t size)
{
char loc_str[128];
- ram_addr_t size_mb;
+ uint64_t size_mb;
SMBIOS_BUILD_TABLE_PRE(17, 0x1100 + instance, true); /* required */
@@ -711,9 +711,9 @@ static void smbios_build_type_17_table(unsigned instance, ram_addr_t size)
}
static void smbios_build_type_19_table(unsigned instance,
- ram_addr_t start, ram_addr_t size)
+ uint64_t start, uint64_t size)
{
- ram_addr_t end, start_kb, end_kb;
+ uint64_t end, start_kb, end_kb;
SMBIOS_BUILD_TABLE_PRE(19, 0x1300 + instance, true); /* required */
--
1.8.3.1
next prev parent reply other threads:[~2014-11-13 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 15:40 [Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2 Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 01/13] esp-pci: fixup deadlock with linux Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 02/13] virtio-scsi: work around bug in old BIOSes Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 03/13] esp: fix coding standards Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 04/13] virtio-scsi: dataplane: fix allocation for 'cmd_vrings' Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 05/13] esp: Do not overwrite ESP_TCHI after reset Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 06/13] virtio-scsi: dataplane: suppress guest notification Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 07/13] virtio-scsi: Fix comment for VirtIOSCSIReq Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 08/13] target-i386: eliminate dead code and hoist common code out of "if" Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 09/13] apic_common: migrate missing fields Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 10/13] target-i386: fix Coverity complaints about overflows Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 11/13] kvmclock: Add comment explaining why we need cpu_clean_all_dirty() Paolo Bonzini
2014-11-13 15:40 ` Paolo Bonzini [this message]
2014-11-13 15:40 ` [Qemu-devel] [PULL 13/13] acpi: accurate overflow check Paolo Bonzini
2014-11-13 16:43 ` [Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415893228-25823-13-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=syeon.hwang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).