From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Subject: [Qemu-devel] [PULL 13/13] acpi: accurate overflow check
Date: Thu, 13 Nov 2014 16:40:28 +0100 [thread overview]
Message-ID: <1415893228-25823-14-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1415893228-25823-1-git-send-email-pbonzini@redhat.com>
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Compare clock in ns, because acpi_pm_tmr_update uses rounded
to ns value instead of ticks.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
[This lets Windows boot in icount mode. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/acpi/core.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index a7368fb..51913d6 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -376,8 +376,11 @@ static void acpi_notify_wakeup(Notifier *notifier, void *data)
/* ACPI PM1a EVT */
uint16_t acpi_pm1_evt_get_sts(ACPIREGS *ar)
{
- int64_t d = acpi_pm_tmr_get_clock();
- if (d >= ar->tmr.overflow_time) {
+ /* Compare ns-clock, not PM timer ticks, because
+ acpi_pm_tmr_update function uses ns for setting the timer. */
+ int64_t d = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
+ if (d >= muldiv64(ar->tmr.overflow_time,
+ get_ticks_per_sec(), PM_TIMER_FREQUENCY)) {
ar->pm1.evt.sts |= ACPI_BITMASK_TIMER_STATUS;
}
return ar->pm1.evt.sts;
--
1.8.3.1
next prev parent reply other threads:[~2014-11-13 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 15:40 [Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2 Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 01/13] esp-pci: fixup deadlock with linux Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 02/13] virtio-scsi: work around bug in old BIOSes Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 03/13] esp: fix coding standards Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 04/13] virtio-scsi: dataplane: fix allocation for 'cmd_vrings' Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 05/13] esp: Do not overwrite ESP_TCHI after reset Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 06/13] virtio-scsi: dataplane: suppress guest notification Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 07/13] virtio-scsi: Fix comment for VirtIOSCSIReq Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 08/13] target-i386: eliminate dead code and hoist common code out of "if" Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 09/13] apic_common: migrate missing fields Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 10/13] target-i386: fix Coverity complaints about overflows Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 11/13] kvmclock: Add comment explaining why we need cpu_clean_all_dirty() Paolo Bonzini
2014-11-13 15:40 ` [Qemu-devel] [PULL 12/13] smbios: change 'ram_addr_t' variables to 'uint64_t' Paolo Bonzini
2014-11-13 15:40 ` Paolo Bonzini [this message]
2014-11-13 16:43 ` [Qemu-devel] [PULL 00/13] x86 and SCSI patches for QEMU 2.2.0-rc2 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415893228-25823-14-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).