From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xp5uE-0000XG-32 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 20:42:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xp5u9-00028t-6M for qemu-devel@nongnu.org; Thu, 13 Nov 2014 20:42:34 -0500 From: zhanghailiang Date: Fri, 14 Nov 2014 09:39:23 +0800 Message-ID: <1415929163-12184-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH] l2tpv3: fix possible double free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: zhanghailiang , qemu-devel@nongnu.org, stefanha@redhat.com, peter.huangpeng@huawei.com freeaddrinfo(result) does not assign result = NULL, after frees it. There will be a double free when it goes error case. It is reported by covertiy. Signed-off-by: zhanghailiang --- net/l2tpv3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 528d95b..f9e0c98 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -661,6 +661,7 @@ int net_init_l2tpv3(const NetClientOptions *opts, fd = -errno; error_report("l2tpv3_open : socket creation failed, errno = %d", -fd); freeaddrinfo(result); + result = NULL; goto outerr; } if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) { -- 1.7.12.4