* [Qemu-devel] [PATCH] gtk: fix possible memory leak about local_err
@ 2014-11-14 3:25 zhanghailiang
2014-11-14 8:29 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: zhanghailiang @ 2014-11-14 3:25 UTC (permalink / raw)
To: qemu-trivial; +Cc: zhanghailiang, peter.huangpeng, kraxel, qemu-devel
local_err in gd_vc_gfx_init() is not freed, and we don't use it,
so remove it.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
ui/gtk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 38bf463..9496b8d 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1666,10 +1666,9 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc,
QemuConsole *con, int idx,
GSList *group, GtkWidget *view_menu)
{
- Error *local_err = NULL;
Object *obj;
- obj = object_property_get_link(OBJECT(con), "device", &local_err);
+ obj = object_property_get_link(OBJECT(con), "device", NULL);
if (obj) {
vc->label = g_strdup_printf("%s", object_get_typename(obj));
} else {
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] gtk: fix possible memory leak about local_err
2014-11-14 3:25 [Qemu-devel] [PATCH] gtk: fix possible memory leak about local_err zhanghailiang
@ 2014-11-14 8:29 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2014-11-14 8:29 UTC (permalink / raw)
To: zhanghailiang; +Cc: qemu-trivial, qemu-devel, peter.huangpeng
On Fr, 2014-11-14 at 11:25 +0800, zhanghailiang wrote:
> local_err in gd_vc_gfx_init() is not freed, and we don't use it,
> so remove it.
Added to gtk patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-14 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-14 3:25 [Qemu-devel] [PATCH] gtk: fix possible memory leak about local_err zhanghailiang
2014-11-14 8:29 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).