From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL for-2.2 01/11] ahci: Fix byte count regression for ATAPI/PIO
Date: Fri, 14 Nov 2014 11:05:47 +0000 [thread overview]
Message-ID: <1415963157-30103-2-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1415963157-30103-1-git-send-email-stefanha@redhat.com>
From: John Snow <jsnow@redhat.com>
This patch fixes a regression caused by commit
659142ecf71a0da240ab0ff7cf929ee25c32b9bc.
The problem occurs when we wish to return early
from the ahci_start_transfer function, but are now
updating the transferred byte count in the AHCI
command header via ahci_commit_buf.
This will cause problems in the Windows 8 installer.
Don't update the byte count in the command header
for the transmission of ATAPI packets: These commands
will distort the final byte count of the actual data
payload.
The call to ahci_commit_buf remains in the "out"
portion of the call in order to clean up the sglist.
The byte count is maintained by forcing size to be 0.
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/ide/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 61dbed1..1f3f951 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1089,6 +1089,7 @@ static void ahci_start_transfer(IDEDMA *dma)
if (is_atapi && !ad->done_atapi_packet) {
/* already prepopulated iobuffer */
ad->done_atapi_packet = true;
+ size = 0;
goto out;
}
--
2.1.0
next prev parent reply other threads:[~2014-11-14 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 11:05 [Qemu-devel] [PULL for-2.2 00/11] Block patches Stefan Hajnoczi
2014-11-14 11:05 ` Stefan Hajnoczi [this message]
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 02/11] ide: repair PIO transfers for cases where nsector > 1 Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 03/11] ahci: unify sglist preparation Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 04/11] ide: Correct handling of malformed/short PRDTs Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 05/11] ahci: add is_ncq predicate helper Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 06/11] ahci: Fix FIS decomposition Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 07/11] ahci: Reorder error cases in handle_cmd Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 08/11] ahci: Check cmd_fis[1] more explicitly Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 09/11] ahci: factor out FIS decomposition from handle_cmd Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 10/11] block: Fix max nb_sectors in bdrv_make_zero Stefan Hajnoczi
2014-11-14 11:05 ` [Qemu-devel] [PULL for-2.2 11/11] vmdk: Leave bdi intact if -ENOTSUP in vmdk_get_info Stefan Hajnoczi
2014-11-14 12:02 ` [Qemu-devel] [PULL for-2.2 00/11] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415963157-30103-2-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).