From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqEUb-0003Ws-9o for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:04:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqEUW-0004gL-Lt for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:04:49 -0500 Received: from [59.151.112.132] (port=59564 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqEUW-0004f1-9M for qemu-devel@nongnu.org; Mon, 17 Nov 2014 00:04:44 -0500 From: Tang Chen Date: Mon, 17 Nov 2014 13:03:36 +0800 Message-ID: <1416200620-11968-10-git-send-email-tangchen@cn.fujitsu.com> In-Reply-To: <1416200620-11968-1-git-send-email-tangchen@cn.fujitsu.com> References: <1416200620-11968-1-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH Part2 09/13] acpi, piix4: Add memory hot unplug support for piix4. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com, pbonzini@redhat.com Cc: guz.fnst@cn.fujitsu.com, hutao@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, zhugh.fnst@cn.fujitsu.com, tangchen@cn.fujitsu.com Call memory unplug cb in piix4_device_unplug_cb(). Signed-off-by: Tang Chen --- hw/acpi/piix4.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 6c7dff9..440c9e8 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -376,8 +376,16 @@ static void piix4_device_unplug_request_cb(HotplugHandler *hotplug_dev, static void piix4_device_unplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { - error_setg(errp, "acpi: device unplug for not supported device" - " type: %s", object_get_typename(OBJECT(dev))); + PIIX4PMState *s = PIIX4_PM(hotplug_dev); + + if (s->acpi_memory_hotplug.is_enabled && + object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { + acpi_memory_unplug_cb(&s->ar, s->irq, &s->acpi_memory_hotplug, + dev, errp); + } else { + error_setg(errp, "acpi: device unplug for not supported device" + " type: %s", object_get_typename(OBJECT(dev))); + } } static void piix4_update_bus_hotplug(PCIBus *pci_bus, void *opaque) -- 1.8.4.2