qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	peter.huangpeng@huawei.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 3/3] virtio-balloon: Add some trace events
Date: Mon, 17 Nov 2014 13:11:10 +0800	[thread overview]
Message-ID: <1416201070-11448-4-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1416201070-11448-1-git-send-email-zhang.zhanghailiang@huawei.com>

Add some trace events for easier debugging

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 hw/virtio/virtio-balloon.c | 6 ++++++
 trace-events               | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 41b24c9..8a48d2a 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -25,6 +25,7 @@
 #include "exec/address-spaces.h"
 #include "qapi/visitor.h"
 #include "qapi-event.h"
+#include "trace.h"
 
 #if defined(__linux__)
 #include <sys/mman.h>
@@ -222,6 +223,8 @@ static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq)
             if (!int128_nz(section.size) || !memory_region_is_ram(section.mr))
                 continue;
 
+            trace_virtio_balloon_handle_output(memory_region_name(section.mr),
+                                               pa);
             /* Using memory_region_get_ram_ptr is bending the rules a bit, but
                should be OK because we only want a single page.  */
             addr = section.offset_within_region;
@@ -285,6 +288,7 @@ static void virtio_balloon_get_config(VirtIODevice *vdev, uint8_t *config_data)
     config.num_pages = cpu_to_le32(dev->num_pages);
     config.actual = cpu_to_le32(dev->actual);
 
+    trace_virtio_balloon_get_config(config.num_pages, config.actual);
     memcpy(config_data, &config, sizeof(struct virtio_balloon_config));
 }
 
@@ -303,6 +307,7 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
                         ((ram_addr_t) dev->actual << VIRTIO_BALLOON_PFN_SHIFT),
                         &error_abort);
     }
+    trace_virtio_balloon_set_config(dev->actual, oldactual);
 }
 
 static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f)
@@ -331,6 +336,7 @@ static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
         dev->num_pages = (vm_ram_size - target) >> VIRTIO_BALLOON_PFN_SHIFT;
         virtio_notify_config(vdev);
     }
+    trace_virtio_balloon_to_target(target, dev->num_pages);
 }
 
 static void virtio_balloon_save(QEMUFile *f, void *opaque)
diff --git a/trace-events b/trace-events
index b5722ea..bba5be8 100644
--- a/trace-events
+++ b/trace-events
@@ -142,6 +142,10 @@ cpu_out(unsigned int addr, unsigned int val) "addr %#x value %u"
 # balloon.c
 # Since requests are raised via monitor, not many tracepoints are needed.
 balloon_event(void *opaque, unsigned long addr) "opaque %p addr %lu"
+virtio_balloon_handle_output(const char *name, uint64_t gpa) "setion name: %s gpa: %"PRIx64""
+virtio_balloon_get_config(uint32_t num_pages, uint32_t acutal) "num_pages: %d acutal: %d"
+virtio_balloon_set_config(uint32_t acutal, uint32_t oldacutal) "acutal: %d oldacutal: %d"
+virtio_balloon_to_target(uint64_t target, uint32_t num_pages) "balloon target: %"PRIx64" num_pages: %d"
 
 # hw/intc/apic_common.c
 cpu_set_apic_base(uint64_t val) "%016"PRIx64
-- 
1.7.12.4

  parent reply	other threads:[~2014-11-17  5:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  5:11 [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory zhanghailiang
2014-11-17  5:11 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: add a function to calculate VM's current RAM size zhanghailiang
2014-11-19  9:59   ` Igor Mammedov
2014-11-19 10:32   ` Michael S. Tsirkin
2014-11-19 15:13     ` Luiz Capitulino
2014-11-19 15:52       ` Eric Blake
2014-11-19 16:06         ` Michael S. Tsirkin
2014-11-19 16:31           ` Eric Blake
2014-11-20  2:31             ` zhanghailiang
2014-11-20  9:10             ` Michael S. Tsirkin
2014-11-20  2:33     ` zhanghailiang
2014-11-17  5:11 ` [Qemu-devel] [PATCH v2 2/3] virtio-balloon: Fix balloon not working correctly when hotplug memory zhanghailiang
2014-11-17  5:11 ` zhanghailiang [this message]
2014-11-17  6:07 ` [Qemu-devel] [PATCH v2 0/3] fix bug about balloon working incorrectly when hotplug memeory Michael S. Tsirkin
2014-11-17 10:39 ` Michael S. Tsirkin
2014-11-17 10:53   ` zhanghailiang
2014-11-17 12:25     ` zhanghailiang
2014-11-17 12:40       ` Michael S. Tsirkin
2014-11-18  2:50         ` zhanghailiang
2014-11-19  8:28 ` zhanghailiang
2014-11-19 10:06   ` Igor Mammedov
2015-03-03 14:04 ` Luiz Capitulino
2015-03-04 12:55   ` zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416201070-11448-4-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).