From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqJOR-0004Mk-QH for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:18:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqJOL-0003DU-5J for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:18:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqJOK-0003DK-VA for qemu-devel@nongnu.org; Mon, 17 Nov 2014 05:18:41 -0500 From: Markus Armbruster Date: Mon, 17 Nov 2014 11:18:31 +0100 Message-Id: <1416219514-22530-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 for-2.2 0/3] raw-posix: Get rid of FIEMAP, fix SEEK_HOLE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, tony@bakeyournoodle.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com PATCH 1 is just a comment fix. PATCH 2 drops FIEMAP use and explains why it needs to go. PATCH 3 carefully rewrites the SEEK_HOLE code. Why 2.2? The series fixes bugs, but the bugs are either not terribly severe, or not particularly likely to bite. The reason I want it included is we've already changed the code fundamentally in 2.2, from Incorrect use of FIEMAP if available, else somewhat incorrect use of SEEK_HOLE if available, else pretend no holes to Somewhat incorrect use of SEEK_HOLE if available, else correct but slow-as-molasses use of FIEMAP if available, else pretend no holes Let's finish the job: Correct use of SEEK_HOLE if available, else pretend no holes Less complex, more robust, and no half-broken intermediate version released. v3: * PATCH 1&2 unchanged, except for a commit message typo [Eric] * PATCH 3&4 redone as PATCH 3, very carefully [Eric, Kevin] v2: * PATCH 1 unchanged * PATCH 2 revised and split up [Paolo, Fam, Eric, Max] Markus Armbruster (3): raw-posix: Fix comment for raw_co_get_block_status() raw-posix: SEEK_HOLE suffices, get rid of FIEMAP raw-posix: The SEEK_HOLE code is flawed, rewrite it block/raw-posix.c | 167 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 86 insertions(+), 81 deletions(-) -- 1.9.3