From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqPn1-0003Q5-Re for qemu-devel@nongnu.org; Mon, 17 Nov 2014 12:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqPmx-00066h-48 for qemu-devel@nongnu.org; Mon, 17 Nov 2014 12:08:35 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 17 Nov 2014 18:08:09 +0100 Message-Id: <1416244099-7217-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1416244099-7217-1-git-send-email-pbonzini@redhat.com> References: <1416244099-7217-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 02/12] l2tpv3: fix possible double free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , qemu-stable@nongnu.org From: zhanghailiang freeaddrinfo(result) does not assign result = NULL, after frees it. There will be a double free when it goes error case. It is reported by covertiy. Reviewed-by: Gonglei Cc: qemu-stable@nongnu.org Signed-off-by: zhanghailiang Signed-off-by: Paolo Bonzini --- net/l2tpv3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 528d95b..65db5ef 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -660,7 +660,6 @@ int net_init_l2tpv3(const NetClientOptions *opts, if (fd == -1) { fd = -errno; error_report("l2tpv3_open : socket creation failed, errno = %d", -fd); - freeaddrinfo(result); goto outerr; } if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) { -- 1.8.3.1