From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqPnE-0003ne-1j for qemu-devel@nongnu.org; Mon, 17 Nov 2014 12:08:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqPn7-00069Z-UL for qemu-devel@nongnu.org; Mon, 17 Nov 2014 12:08:47 -0500 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:45425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqPn7-00069U-OR for qemu-devel@nongnu.org; Mon, 17 Nov 2014 12:08:41 -0500 Received: by mail-wi0-f171.google.com with SMTP id bs8so3968190wib.10 for ; Mon, 17 Nov 2014 09:08:41 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 17 Nov 2014 18:08:15 +0100 Message-Id: <1416244099-7217-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1416244099-7217-1-git-send-email-pbonzini@redhat.com> References: <1416244099-7217-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 08/12] acl: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gonglei From: Gonglei If 'i != index' for all acl->entries, variable entry leaks the storage it points to. Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- util/acl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/util/acl.c b/util/acl.c index 938b7ae..571d686 100644 --- a/util/acl.c +++ b/util/acl.c @@ -132,7 +132,6 @@ int qemu_acl_insert(qemu_acl *acl, const char *match, int index) { - qemu_acl_entry *entry; qemu_acl_entry *tmp; int i = 0; @@ -142,13 +141,14 @@ int qemu_acl_insert(qemu_acl *acl, return qemu_acl_append(acl, deny, match); } - entry = g_malloc(sizeof(*entry)); - entry->match = g_strdup(match); - entry->deny = deny; - QTAILQ_FOREACH(tmp, &acl->entries, next) { i++; if (i == index) { + qemu_acl_entry *entry; + entry = g_malloc(sizeof(*entry)); + entry->match = g_strdup(match); + entry->deny = deny; + QTAILQ_INSERT_BEFORE(tmp, entry, next); acl->nentries++; break; -- 1.8.3.1