[Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed

[Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed

[Fam Zheng]

When which(1) is not installed, we complain "perl not found" because
it's the first set_prog_path check. The error message is misleading.

Fix it by adding a check for which(1) in the beginning.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/common.config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config
index bd6790b..9674f3a 100644
--- a/tests/qemu-iotests/common.config
+++ b/tests/qemu-iotests/common.config
@@ -73,6 +73,8 @@ _fatal()
     exit 1
 }
 
+which -v &>/dev/null || _fatal "which not found"
+
 export PERL_PROG="`set_prog_path perl`"
 [ "$PERL_PROG" = "" ] && _fatal "perl not found"
 
-- 
1.9.3

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix error message if which(1) not installed

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

On 11/17/2014 07:49 PM, Fam Zheng wrote:
> When which(1) is not installed, we complain "perl not found" because
> it's the first set_prog_path check. The error message is misleading.
> 
> Fix it by adding a check for which(1) in the beginning.

Why not instead change set_prog_path to use 'command -v' instead of
'which'?  As this is a bash script, we shouldn't need to shell out to an
optional package for something we can do natively.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]