* [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control()
@ 2014-11-19 6:57 Jun Li
2014-11-19 7:09 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jun Li @ 2014-11-19 6:57 UTC (permalink / raw)
To: qemu-devel; +Cc: juli, famz, kraxel, Jun Li
When see usb codes, find there are redundant brackets !((udev->port->speedmask
& USB_SPEED_MASK_SUPER)) here. So delete it.
Signed-off-by: Jun Li <junmuzi@gmail.com>
---
hw/usb/host-libusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index a5f9dab..cff4f7c 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -1237,7 +1237,7 @@ static void usb_host_handle_control(USBDevice *udev, USBPacket *p,
/* Fix up USB-3 ep0 maxpacket size to allow superspeed connected devices
* to work redirected to a not superspeed capable hcd */
if (udev->speed == USB_SPEED_SUPER &&
- !((udev->port->speedmask & USB_SPEED_MASK_SUPER)) &&
+ !(udev->port->speedmask & USB_SPEED_MASK_SUPER) &&
request == 0x8006 && value == 0x100 && index == 0) {
r->usb3ep0quirk = true;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control()
2014-11-19 6:57 [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control() Jun Li
@ 2014-11-19 7:09 ` Fam Zheng
2014-12-10 8:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2014-11-19 7:09 UTC (permalink / raw)
To: Jun Li; +Cc: qemu-trivial, juli, qemu-devel, kraxel
On Wed, 11/19 14:57, Jun Li wrote:
> When see usb codes, find there are redundant brackets !((udev->port->speedmask
> & USB_SPEED_MASK_SUPER)) here. So delete it.
>
> Signed-off-by: Jun Li <junmuzi@gmail.com>
> ---
> hw/usb/host-libusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
> index a5f9dab..cff4f7c 100644
> --- a/hw/usb/host-libusb.c
> +++ b/hw/usb/host-libusb.c
> @@ -1237,7 +1237,7 @@ static void usb_host_handle_control(USBDevice *udev, USBPacket *p,
> /* Fix up USB-3 ep0 maxpacket size to allow superspeed connected devices
> * to work redirected to a not superspeed capable hcd */
> if (udev->speed == USB_SPEED_SUPER &&
> - !((udev->port->speedmask & USB_SPEED_MASK_SUPER)) &&
> + !(udev->port->speedmask & USB_SPEED_MASK_SUPER) &&
> request == 0x8006 && value == 0x100 && index == 0) {
> r->usb3ep0quirk = true;
> }
> --
> 1.9.3
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
Cc'ing qemu-trivial@nongnu.org.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] usb: delete redundant brackets in usb_host_handle_control()
2014-11-19 7:09 ` Fam Zheng
@ 2014-12-10 8:24 ` Michael Tokarev
0 siblings, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2014-12-10 8:24 UTC (permalink / raw)
To: Fam Zheng, Jun Li; +Cc: qemu-trivial, juli, qemu-devel, kraxel
19.11.2014 10:09, Fam Zheng wrote:
> On Wed, 11/19 14:57, Jun Li wrote:
>> When see usb codes, find there are redundant brackets !((udev->port->speedmask
>> & USB_SPEED_MASK_SUPER)) here. So delete it.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-10 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-19 6:57 [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control() Jun Li
2014-11-19 7:09 ` Fam Zheng
2014-12-10 8:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).