From: Gerd Hoffmann <kraxel@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: remove spice-experimental.h include
Date: Wed, 19 Nov 2014 10:55:14 +0100 [thread overview]
Message-ID: <1416390914.3419.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <546A2E1B.10609@msgid.tls.msk.ru>
On Mo, 2014-11-17 at 20:19 +0300, Michael Tokarev wrote:
> 17.11.2014 18:52, Marc-André Lureau wrote:
> > Nothing seems to be using functions from spice-experimental.h (better
> > that way). Let's remove its inclusion.
>
> Is it with current spice, or with some older spice too?
> I mean, why this include has been added to start with -- was it
> because of some feature which initially was only in -experimental.h
> but later moved to main spice? If yes, it'd be interesting to see
> when, in which version of spice, that has been done. Or at least
> to verify that the minimal version of spice required by qemu (in
> configure) allows to stop including -experimental.h....
>
> So basically, my only question here is -- what version of spice
> did you check -- especially, did you check the current minimal
> required version too?
minimum required spice-server is 0.12.0. IIRC the char channel stuff
used to be in experimental, but I think that predates 0.12.0. Marc?
cheers,
Gerd
next prev parent reply other threads:[~2014-11-19 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:52 [Qemu-devel] [PATCH] spice: remove spice-experimental.h include Marc-André Lureau
2014-11-17 17:19 ` Michael Tokarev
2014-11-19 9:55 ` Gerd Hoffmann [this message]
2014-11-19 15:25 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416390914.3419.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).