From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xr1yx-0003nx-68
	for qemu-devel@nongnu.org; Wed, 19 Nov 2014 04:55:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xr1yr-0004v6-1l
	for qemu-devel@nongnu.org; Wed, 19 Nov 2014 04:55:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Xr1yq-0004v0-QQ
	for qemu-devel@nongnu.org; Wed, 19 Nov 2014 04:55:20 -0500
Message-ID: <1416390914.3419.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 19 Nov 2014 10:55:14 +0100
In-Reply-To: <546A2E1B.10609@msgid.tls.msk.ru>
References: <1416239569-28946-1-git-send-email-marcandre.lureau@gmail.com>
	<546A2E1B.10609@msgid.tls.msk.ru>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] spice: remove spice-experimental.h include
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org

On Mo, 2014-11-17 at 20:19 +0300, Michael Tokarev wrote:
> 17.11.2014 18:52, Marc-Andr=C3=A9 Lureau wrote:
> > Nothing seems to be using functions from spice-experimental.h (better
> > that way). Let's remove its inclusion.
>=20
> Is it with current spice, or with some older spice too?
> I mean, why this include has been added to start with -- was it
> because of some feature which initially was only in -experimental.h
> but later moved to main spice?  If yes, it'd be interesting to see
> when, in which version of spice, that has been done.  Or at least
> to verify that the minimal version of spice required by qemu (in
> configure) allows to stop including -experimental.h....
>=20
> So basically, my only question here is -- what version of spice
> did you check -- especially, did you check the current minimal
> required version too?

minimum required spice-server is 0.12.0.  IIRC the char channel stuff
used to be in experimental, but I think that predates 0.12.0.  Marc?

cheers,
  Gerd