From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrTe3-0002Jd-2j for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:27:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrTdw-0003q2-VC for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:27:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrTdw-0003pu-OU for qemu-devel@nongnu.org; Thu, 20 Nov 2014 10:27:36 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKFRZMn029591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 10:27:36 -0500 From: Kevin Wolf Date: Thu, 20 Nov 2014 16:27:13 +0100 Message-Id: <1416497234-29880-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1416497234-29880-1-git-send-email-kwolf@redhat.com> References: <1416497234-29880-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v3 8/9] qemu-iotests: Fix stderr handling in common.qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com The original intention was to pipe stderr of qemu into $fifo_out. However, the redirections were specified in the wrong order for this. This patch fixes it. Now qemu's output on stderr can be retrieved with _send_qemu_cmd, which applies several useful filters on the output that were missing before. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/common.qemu | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.qemu b/tests/qemu-iotests/common.qemu index ee7ebb4..8e618b5 100644 --- a/tests/qemu-iotests/common.qemu +++ b/tests/qemu-iotests/common.qemu @@ -153,8 +153,9 @@ function _launch_qemu() mkfifo "${fifo_out}" mkfifo "${fifo_in}" - "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" 2>&1 \ + "${QEMU}" -nographic -serial none ${comm} -machine accel=qtest "${@}" \ >"${fifo_out}" \ + 2>&1 \ <"${fifo_in}" & QEMU_PID[${_QEMU_HANDLE}]=$! -- 1.8.3.1