From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVCf-0004Fz-Fu for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:07:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrVCZ-0000wI-BW for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:07:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrVCZ-0000vJ-3k for qemu-devel@nongnu.org; Thu, 20 Nov 2014 12:07:27 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKH7PUt028482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 12:07:26 -0500 From: Max Reitz Date: Thu, 20 Nov 2014 18:06:37 +0100 Message-Id: <1416503198-17031-22-git-send-email-mreitz@redhat.com> In-Reply-To: <1416503198-17031-1-git-send-email-mreitz@redhat.com> References: <1416503198-17031-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v3 21/22] qcow2: Point to amend function in check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Max Reitz If a reference count is not representable with the current refcount order, the image check should point to qemu-img amend for increasing the refcount order. However, qemu-img amend needs write access to the image which cannot be provided if the image is marked corrupt; and the image check will not mark the image consistent unless everything actually is consistent. Therefore, if an image is marked corrupt and the image check encounters a reference count overflow, it cannot be fixed by using qemu-img amend to increase the refcount order. Instead, one has to use qemu-img convert to create a completely new copy of the image in this case. Alternatively, we may want to give the user a way of manually removing the corrupt flag, maybe through qemu-img amend, but this is not part of this patch. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index d619728..9201d30 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -1360,6 +1360,9 @@ static int inc_refcounts(BlockDriverState *bs, if (refcount == s->refcount_max) { fprintf(stderr, "ERROR: overflow cluster offset=0x%" PRIx64 "\n", cluster_offset); + fprintf(stderr, "Use qemu-img amend to increase the refcount entry " + "width or qemu-img convert to create a clean copy if the " + "image cannot be opened for writing\n"); res->corruptions++; continue; } -- 1.9.3