From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XriW8-0004hH-U2 for qemu-devel@nongnu.org; Fri, 21 Nov 2014 02:20:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XriW2-0006ug-Mm for qemu-devel@nongnu.org; Fri, 21 Nov 2014 02:20:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XriW2-0006uK-FL for qemu-devel@nongnu.org; Fri, 21 Nov 2014 02:20:26 -0500 Message-ID: <1416554419.29248.1.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Fri, 21 Nov 2014 08:20:19 +0100 In-Reply-To: <20141120170345.GA30305@morn.localdomain> References: <1416284800-2759-1-git-send-email-kevin@koconnor.net> <1416284800-2759-4-git-send-email-kevin@koconnor.net> <546AE6CC.7040606@redhat.com> <20141120170345.GA30305@morn.localdomain> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] sdhci: Support SDHCI devices on PCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Paolo Bonzini , qemu-devel@nongnu.org Hi, > I know recent Intel chips (eg, baytrail) have a builtin sdhci > controller (eg, 8086:0f16). However, that has quirks defined in the > Linux driver. Basic functionality still does seem to work though when > I use those ids in qemu. The same basic functionality also seems to > work when I use 1b36:0005 as well. > > Is there a preference then to use the redhat ids? Yes, for pci class devices (so the guest driver do not match specific pci vendor/device ids, except for quirks) we started using the redhat ids. > Gerd, you seem to > be in charge of the redhat pci ids - are you okay if I us one (should > it be the existing 0005 or add 0006)? Just grab the first free (which seems to be 0005) and add a line to docs/specs/pci-ids.txt with your patch. cheers, Gerd