From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrkTF-0005MX-Av for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:25:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrkTA-0003HZ-8L for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:25:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrkT9-0003HN-DT for qemu-devel@nongnu.org; Fri, 21 Nov 2014 04:25:35 -0500 From: Gerd Hoffmann Date: Fri, 21 Nov 2014 10:25:11 +0100 Message-Id: <1416561912-8877-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1416561912-8877-1-git-send-email-kraxel@redhat.com> References: <1416561912-8877-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL for-2.2 1/2] gtk: fix possible memory leak about local_err List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: zhanghailiang , Anthony Liguori , Gerd Hoffmann From: zhanghailiang local_err in gd_vc_gfx_init() is not freed, and we don't use it, so remove it. Signed-off-by: zhanghailiang Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 38bf463..9496b8d 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1666,10 +1666,9 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, QemuConsole *con, int idx, GSList *group, GtkWidget *view_menu) { - Error *local_err = NULL; Object *obj; - obj = object_property_get_link(OBJECT(con), "device", &local_err); + obj = object_property_get_link(OBJECT(con), "device", NULL); if (obj) { vc->label = g_strdup_printf("%s", object_get_typename(obj)); } else { -- 1.8.3.1