From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrm9A-0003t0-HS for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:13:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrm95-0005fp-KL for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:13:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrm95-0005fY-Dv for qemu-devel@nongnu.org; Fri, 21 Nov 2014 06:12:59 -0500 From: Stefan Hajnoczi Date: Fri, 21 Nov 2014 11:12:37 +0000 Message-Id: <1416568359-6750-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1416568359-6750-1-git-send-email-stefanha@redhat.com> References: <1416568359-6750-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL for-2.2 2/4] net/socket: fix Uninitialized scalar variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Gonglei , Stefan Hajnoczi From: Gonglei If is_connected parameter is false, the saddr variable will no initialize. Coverity report: uninit_use: Using uninitialized value saddr.sin_port. We don't need add saddr information to nc->info_str when is_connected is false. Signed-off-by: Gonglei Reviewed-by: Jason Wang Signed-off-by: Stefan Hajnoczi --- net/socket.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/socket.c b/net/socket.c index ca4b8ba..68a93cd 100644 --- a/net/socket.c +++ b/net/socket.c @@ -389,11 +389,6 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, nc = qemu_new_net_client(&net_dgram_socket_info, peer, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d (%s mcast=%s:%d)", - fd, is_connected ? "cloned" : "", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); - s = DO_UPCAST(NetSocketState, nc, nc); s->fd = fd; @@ -404,6 +399,12 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer, /* mcast: save bound address as dst */ if (is_connected) { s->dgram_dst = saddr; + snprintf(nc->info_str, sizeof(nc->info_str), + "socket: fd=%d (cloned mcast=%s:%d)", + fd, inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + } else { + snprintf(nc->info_str, sizeof(nc->info_str), + "socket: fd=%d", fd); } return s; -- 2.1.0