From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 03/15] pc: make pc_dimm_plug() more readble
Date: Sun, 23 Nov 2014 13:17:46 +0200 [thread overview]
Message-ID: <1416741307-32307-4-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416741307-32307-1-git-send-email-mst@redhat.com>
From: Igor Mammedov <imammedo@redhat.com>
split addr initialization from declaration so that
later when new local vars are added property getter
wouldn't drift off of error check.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/pc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index ce7b752..70ae3cf 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1556,8 +1556,9 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
PCDIMMDevice *dimm = PC_DIMM(dev);
PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
MemoryRegion *mr = ddc->get_memory_region(dimm);
- uint64_t addr = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP,
- &local_err);
+ uint64_t addr;
+
+ addr = object_property_get_int(OBJECT(dimm), PC_DIMM_ADDR_PROP, &local_err);
if (local_err) {
goto out;
}
--
MST
next prev parent reply other threads:[~2014-11-23 11:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 11:17 [Qemu-devel] [PULL 00/15] pc, pci, misc bugfixes Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 01/15] qemu-char: fix tcp_get_fds Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 02/15] pc: kvm: check if KVM has free memory slots to avoid abort() Michael S. Tsirkin
2014-11-23 11:17 ` Michael S. Tsirkin [this message]
2014-11-23 11:17 ` [Qemu-devel] [PULL 04/15] pc: limit DIMM address and size to page aligned values Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 05/15] memory: expose alignment used for allocating RAM as MemoryRegion API Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 06/15] pc: align DIMM's address/size by backend's alignment value Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 07/15] pc: pc-dimm: use backend alignment during address auto allocation Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 08/15] pc: explicitly check maxmem limit when adding DIMM Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 09/15] pc: count in 1Gb hugepage alignment when sizing hotplug-memory container Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 10/15] hw/pci: fix crash on shpc error flow Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 11/15] acpi-build: mark RAM dirty on table update Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 12/15] target-i386: move generic memory hotplug methods to DSDTs Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 13/15] pcie: fix typo in pcie_cap_deverr_init() Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 14/15] pcie: fix improper use of negative value Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 15/15] pc: acpi: mark all possible CPUs as enabled in SRAT Michael S. Tsirkin
2014-11-24 13:07 ` [Qemu-devel] [PULL 00/15] pc, pci, misc bugfixes Peter Maydell
2014-11-24 14:16 ` [Qemu-devel] [PATCH 08/15] fixup! pc: explicitly check maxmem limit when adding DIMM Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416741307-32307-4-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).