qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com
Subject: [Qemu-devel] [PATCH 08/15] fixup! pc: explicitly check maxmem limit when adding DIMM
Date: Mon, 24 Nov 2014 14:16:38 +0000	[thread overview]
Message-ID: <1416838598-15989-1-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <CAFEAcA9i+8xT7y=2S16Lk-rwEg0usL-M9iC4yAs0eqmqeUhXug@mail.gmail.com>

Fix build breakage on 32 bit host:

hw/i386/pc.c:1623:9: error: format '%llx' expects argument
of type 'long long unsigned int', but argument 5 has type 'ram_addr_t'
[-Werror=format]

introduced by:
  pc: explicitly check maxmem limit when adding DIMM

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e656658..8be50a4 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1621,7 +1621,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
     if (existing_dimms_capacity + memory_region_size(mr) >
         machine->maxram_size - machine->ram_size) {
         error_setg(&local_err, "not enough space, currently 0x%" PRIx64
-                   " in use of total 0x%" PRIx64,
+                   " in use of total 0x" RAM_ADDR_FMT,
                    existing_dimms_capacity, machine->maxram_size);
         goto out;
     }
-- 
1.8.3.1

      reply	other threads:[~2014-11-24 14:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23 11:17 [Qemu-devel] [PULL 00/15] pc, pci, misc bugfixes Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 01/15] qemu-char: fix tcp_get_fds Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 02/15] pc: kvm: check if KVM has free memory slots to avoid abort() Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 03/15] pc: make pc_dimm_plug() more readble Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 04/15] pc: limit DIMM address and size to page aligned values Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 05/15] memory: expose alignment used for allocating RAM as MemoryRegion API Michael S. Tsirkin
2014-11-23 11:17 ` [Qemu-devel] [PULL 06/15] pc: align DIMM's address/size by backend's alignment value Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 07/15] pc: pc-dimm: use backend alignment during address auto allocation Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 08/15] pc: explicitly check maxmem limit when adding DIMM Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 09/15] pc: count in 1Gb hugepage alignment when sizing hotplug-memory container Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 10/15] hw/pci: fix crash on shpc error flow Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 11/15] acpi-build: mark RAM dirty on table update Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 12/15] target-i386: move generic memory hotplug methods to DSDTs Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 13/15] pcie: fix typo in pcie_cap_deverr_init() Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 14/15] pcie: fix improper use of negative value Michael S. Tsirkin
2014-11-23 11:18 ` [Qemu-devel] [PULL 15/15] pc: acpi: mark all possible CPUs as enabled in SRAT Michael S. Tsirkin
2014-11-24 13:07 ` [Qemu-devel] [PULL 00/15] pc, pci, misc bugfixes Peter Maydell
2014-11-24 14:16   ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416838598-15989-1-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).