From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGn4-0000b2-50 for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:08:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtGmx-0006gf-LK for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:08:26 -0500 From: Max Reitz Date: Tue, 25 Nov 2014 15:07:53 +0100 Message-Id: <1416924485-13304-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 00/12] block: Various Coverity-spotted fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , qemu-stable@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Max Reitz This series fixes various issues spotted by Coverity. None of these is critical; most are just "If you do something crazy, qemu-img crashes" or "But what if there is no qcow2 driver?". Therefore, while these are bug fixes, it is a bit late to try to push them into 2.2.0. I am therefore tempted to vote to target 2.3 instead. Also, none is security-relevant. The only crashes which are fixed here are sure to have resulted from dereferencing a NULL pointer. Max Reitz (12): block: qcow2 driver may not be found block/vvfat: qcow driver may not be found block/nfs: Add create_opts block: Check create_opts before image creation qemu-img: Check create_opts before image creation qemu-img: Check create_opts before image amendment iotests: Only kill NBD server if it runs iotests: Add test for unsupported image creation qcow2: Prevent numerical overflow qcow2: Flushing the caches in qcow2_close may fail qcow2: Respect bdrv_truncate() error block/raw-posix: Fix ret in raw_open_common() block.c | 18 +++++++++++ block/nfs.c | 15 +++++++++ block/qcow2-cluster.c | 2 +- block/qcow2.c | 22 ++++++++++--- block/raw-posix.c | 1 + block/vvfat.c | 6 ++++ qemu-img.c | 21 ++++++++++++ tests/qemu-iotests/113 | 76 ++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/113.out | 15 +++++++++ tests/qemu-iotests/common.rc | 4 ++- tests/qemu-iotests/group | 1 + 11 files changed, 174 insertions(+), 7 deletions(-) create mode 100755 tests/qemu-iotests/113 create mode 100644 tests/qemu-iotests/113.out -- 1.9.3