From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55060)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1XtH2g-00056N-8x
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:24:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1XtH2Y-0004cz-JA
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:24:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1XtH2Y-0004cl-B4
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 09:24:26 -0500
Message-ID: <1416925404.4666.40.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Tue, 25 Nov 2014 16:23:24 +0200
In-Reply-To: <20141125091256.03b81a5b@redhat.com>
References: <1416924259.4666.38.camel@localhost.localdomain>
	<20141125091256.03b81a5b@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Regression] hmp: QEMU crash on device_del
	auto-completion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>

On Tue, 2014-11-25 at 09:12 -0500, Luiz Capitulino wrote:
> On Tue, 25 Nov 2014 16:04:19 +0200
> Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> 
> > Hi,
> > 
> > The commits:
> >  - 6a1fa9f5 (monitor: add del completion for peripheral device) 
> >  - 66e56b13 (qdev: add qdev_build_hotpluggable_device_list helper)
> > 
> > cause a QEMU crash when trying to use HMP device_del auto-completion.
> > It can be easily reproduced by:
> > <qemu-bin> -enable-kvm  ~/images/fedora.qcow2 -monitor stdio -device virtio-net-pci,id=vnet
> > (qemu) device_del /home/mapfelba/git/upstream/qemu/hw/core/qdev.c:941:qdev_build_hotpluggable_device_list: Object 0x7f6ce04e4fe0 is not an instance of type device
> > Aborted (core dumped)
> > 
> > The root cause is qdev_build_hotpluggable_device_list going recursively over
> > all peripherals and their children assuming all are devices. It doesn't work
> > since PCI devices have at least on child which is a memory region (bus master).
> > 
> > Should we try to fix it for 2.2 or simply revert it?
> 
> Do you think you can post a patch in the next few days? If you can then
> let's try to fix it, otherwise we better revert those commits.

I'll try, sure.
Thanks,
Marcel