From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfKq-0002cx-Ua for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:21:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtfKb-0000xy-GO for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:20:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtfKa-0000wm-Ia for qemu-devel@nongnu.org; Wed, 26 Nov 2014 11:20:40 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQGKdeK019901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 11:20:40 -0500 From: Max Reitz Date: Wed, 26 Nov 2014 17:20:27 +0100 Message-Id: <1417018829-15002-5-git-send-email-mreitz@redhat.com> In-Reply-To: <1417018829-15002-1-git-send-email-mreitz@redhat.com> References: <1417018829-15002-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v4 4/6] block: Relative backing file for image creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , Max Reitz Relative backing filenames are always relative to the backed image's directory; the same applies to image creation. Therefore, if the backing file has to be opened for determining its size (in case the size has not been explicitly specified) its filename should be interpreted relative to the new image's base directory and not relative to qemu's working directory. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Fam Zheng --- block.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 0d1869c..65f31ef 100644 --- a/block.c +++ b/block.c @@ -5634,16 +5634,26 @@ void bdrv_img_create(const char *filename, const char *fmt, if (size == -1) { if (backing_file) { BlockDriverState *bs; + char *full_backing = g_new0(char, PATH_MAX); int64_t size; int back_flags; + bdrv_get_full_backing_filename_from_filename(filename, backing_file, + full_backing, PATH_MAX, + &local_err); + if (local_err) { + g_free(full_backing); + goto out; + } + /* backing files always opened read-only */ back_flags = flags & ~(BDRV_O_RDWR | BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING); bs = NULL; - ret = bdrv_open(&bs, backing_file, NULL, NULL, back_flags, + ret = bdrv_open(&bs, full_backing, NULL, NULL, back_flags, backing_drv, &local_err); + g_free(full_backing); if (ret < 0) { goto out; } -- 1.9.3